Return-path: Received: from mga01.intel.com ([192.55.52.88]:21411 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752518AbdDDQV7 (ORCPT ); Tue, 4 Apr 2017 12:21:59 -0400 Message-ID: <1491322606.708.133.camel@linux.intel.com> (sfid-20170404_182203_079566_6F193B78) Subject: Re: [PATCH v2 1/5] NFC: st21nfca: Fix obvious typo when check error code From: Andy Shevchenko To: Lauro Ramos Venancio , Aloisio Almeida Jr , Samuel Ortiz , linux-wireless@vger.kernel.org, Christophe Ricard Date: Tue, 04 Apr 2017 19:16:46 +0300 In-Reply-To: <20170307102546.32224-1-andriy.shevchenko@linux.intel.com> References: <20170307102546.32224-1-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, 2017-03-07 at 12:25 +0200, Andy Shevchenko wrote: > We return -ENODEV if ACPI provides a GPIO resource. Looks really > wrong. > If it has even been tested? Samuel, Christophe, anything I have to address? > > Signed-off-by: Andy Shevchenko > --- >  drivers/nfc/st21nfca/i2c.c | 4 ++-- >  1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/nfc/st21nfca/i2c.c b/drivers/nfc/st21nfca/i2c.c > index 5a82f553906c..737384d287aa 100644 > --- a/drivers/nfc/st21nfca/i2c.c > +++ b/drivers/nfc/st21nfca/i2c.c > @@ -514,9 +514,9 @@ static int > st21nfca_hci_i2c_acpi_request_resources(struct i2c_client *client) >   /* Get EN GPIO from ACPI */ >   gpiod_ena = devm_gpiod_get_index(dev, ST21NFCA_GPIO_NAME_EN, > 1, >    GPIOD_OUT_LOW); > - if (!IS_ERR(gpiod_ena)) { > + if (IS_ERR(gpiod_ena)) { >   nfc_err(dev, "Unable to get ENABLE GPIO\n"); > - return -ENODEV; > + return PTR_ERR(gpiod_ena); >   } >   >   phy->gpio_ena = desc_to_gpio(gpiod_ena); -- Andy Shevchenko Intel Finland Oy