Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:46638 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751406AbdDCLwy (ORCPT ); Mon, 3 Apr 2017 07:52:54 -0400 From: Kalle Valo To: Arend Van Spriel Cc: =?utf-8?Q?Rafa=C5=82_Mi=C5=82ecki?= , linux-wireless , Franky Lin Subject: Re: [PATCH 1/5] brcmfmac: wrap brcmf_fws_init into bcdc layer References: <1490697808-5538-1-git-send-email-arend.vanspriel@broadcom.com> <1490697808-5538-2-git-send-email-arend.vanspriel@broadcom.com> Date: Mon, 03 Apr 2017 14:52:49 +0300 In-Reply-To: (Arend Van Spriel's message of "Thu, 30 Mar 2017 10:08:04 +0200") Message-ID: <87vaqln1wu.fsf@kamboji.qca.qualcomm.com> (sfid-20170403_135257_748695_0C53B992) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: Arend Van Spriel writes: > On 29-3-2017 13:18, Rafa=C5=82 Mi=C5=82ecki wrote: >> On 03/28/2017 12:43 PM, Arend van Spriel wrote: >>> From: Franky Lin >>> >>> Create a new protocol layer interface brcmf_proto_init_cb for protocol >>> layer to finish initialzation after core module components(fweh and >>> etc.) are initialized. >>> >>> Signed-off-by: Franky Lin >>> Change-Id: I560d2478a7c09766cf07b20d74b31dff5ca6ac7b >>> Reviewed-on: http://hnd-swgit.sj.broadcom.com:8080/8156 >>=20 >> These 2 lines are rather useless. > > Sorry. Our Gerrit server adds these and I make an effort to remove this > before submitting, but every now and then a few slip through. > >>> Reviewed-by: brcm80211 ci >>=20 >> Please use full names only. > > Sure thing. This is actually Jenkins account we use for building and > smoketesting the driver. I'll remove these from patches 1-4 during commit. (patch 5 seems to be ok) --=20 Kalle Valo