Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:40358 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762201AbdDYHtS (ORCPT ); Tue, 25 Apr 2017 03:49:18 -0400 From: Kalle Valo To: Arend Van Spriel Cc: James Hughes , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, netdev@vger.kernel.org Subject: Re: [PATCH v2] brcmfmac: Make skb header writable before use References: <20170424130322.476-1-james.hughes@raspberrypi.org> Date: Tue, 25 Apr 2017 10:49:11 +0300 In-Reply-To: (Arend Van Spriel's message of "Tue, 25 Apr 2017 09:46:16 +0200") Message-ID: <87h91d0vwo.fsf@kamboji.qca.qualcomm.com> (sfid-20170425_094925_823840_883496E6) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org List-ID: Arend Van Spriel writes: > On 25-4-2017 9:38, Arend Van Spriel wrote: >> On 24-4-2017 15:03, James Hughes wrote: >>> The driver was making changes to the skb_header without >>> ensuring it was writable (i.e. uncloned). >>> This patch also removes some boiler plate header size >>> checking/adjustment code as that is also handled by the >>> skb_cow_header function used to make header writable. >>> >>> This patch depends on >>> brcmfmac: Ensure pointer correctly set if skb data location changes >>> >>> Signed-off-by: James Hughes >>> --- >>> Changes in v2 >>> Makes the _cow_ call at the entry point of the skb in to the >>> stack, means only needs to be done once, and error handling >>> is easier. >>> Split a separate minor bug fix off to a separate patch (which >>> this patch depends on) >> >> Hi James, >> >> Can you please indicate in this section that you want it applied for >> 4.12 as it is an important fix. Probably will have to wait until after >> the merge window before it can get in the wireless-drivers repo. > > Hi Kalle, > > I should have checked kernel mailing list first as Linus added another > rc cycle. So can this patch still go in wireless-drivers-next for 4.12 > kernel. Yup, I'll queue it for 4.12. > I want it for stable as well, but I will look at that when it lands > upstream. Ok, so I don't add any stable tag during commit. -- Kalle Valo