Return-path: Received: from wolverine02.qualcomm.com ([199.106.114.251]:24601 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752541AbdEIMUn (ORCPT ); Tue, 9 May 2017 08:20:43 -0400 From: Kalle Valo To: Arend Van Spriel CC: "Gustavo A. R. Silva" , "netdev@vger.kernel.org" , "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "ath10k@lists.infradead.org" Subject: Re: [PATCH] net: wireless: ath: ath10k: remove unnecessary code Date: Tue, 9 May 2017 12:20:40 +0000 Message-ID: <87wp9qz0fd.fsf@kamboji.qca.qualcomm.com> (sfid-20170509_142123_497725_9A37F9E2) References: <20170509042159.GA19727@embeddedgus> <87lgq6387s.fsf@kamboji.qca.qualcomm.com> <76408651-07c6-fe31-863f-e1cb73b49663@broadcom.com> In-Reply-To: <76408651-07c6-fe31-863f-e1cb73b49663@broadcom.com> (Arend Van Spriel's message of "Tue, 9 May 2017 14:07:57 +0200") Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: Arend Van Spriel writes: > On 9-5-2017 7:33, Kalle Valo wrote: >> "Gustavo A. R. Silva" writes: >>=20 >>> The name of an array used by itself will always return the array's addr= ess. >>> So these tests will always evaluate as false and therefore the _return_ >>> will never be executed. >>> >>> Signed-off-by: Gustavo A. R. Silva >>=20 >> I don't understand the commit log, especially what does "The name of an >> array used by itself" mean? > > The array fields in struct wmi_start_scan_arg that are checked here are > fixed size arrays so they can never be NULL. > > Maybe that helps rephrasing this commit message. Much much better, thanks! --=20 Kalle Valo=