Return-path: <linux-wireless-owner@vger.kernel.org>
Received: from mail-wm0-f48.google.com ([74.125.82.48]:36646 "EHLO
        mail-wm0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1754974AbdESTYp (ORCPT
        <rfc822;linux-wireless@vger.kernel.org>);
        Fri, 19 May 2017 15:24:45 -0400
Received: by mail-wm0-f48.google.com with SMTP id 7so9998788wmo.1
        for <linux-wireless@vger.kernel.org>; Fri, 19 May 2017 12:24:44 -0700 (PDT)
Subject: Re: New brcmfmac errors in 4.12: brcmf_sdio_rxglom: sublen ... not
 multiple of 8
To: Heiner Kallweit <hkallweit1@gmail.com>,
        Hante Meuleman <hante.meuleman@broadcom.com>,
        Helmut Klein <hgkr.klein@gmail.com>
References: <e8055bc7-eaf4-1ab6-31d1-130d83485980@redhat.com>
 <540e89cd-c222-e81a-5e34-600ae0aa052e@redhat.com>
 <701cc6a7-b66b-8a51-8755-13dd584cbebd@gmail.com>
 <cf896651-18a6-ee07-62a4-437c191ddde4@redhat.com>
 <a4cf8400-3b11-4d09-9b46-6d6382423ce7@broadcom.com>
 <af025144-3d74-7d5f-30ea-7bb9b0f89c39@redhat.com>
 <8caf5612-b28c-d101-9b99-934b11e5d57c@broadcom.com>
 <90e8392d-5b18-6ce0-56ed-23dc6df606c7@gmail.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
        Franky Lin <franky.lin@broadcom.com>,
        Kalle Valo <kvalo@codeaurora.org>,
        linux-wireless <linux-wireless@vger.kernel.org>,
        brcm80211-dev-list.pdl@broadcom.com
From: Arend Van Spriel <arend.vanspriel@broadcom.com>
Message-ID: <a6cac038-8fda-b8dc-6cef-eb2fa0c69b22@broadcom.com> (sfid-20170519_212450_219567_EA6C12B1)
Date: Fri, 19 May 2017 21:24:42 +0200
MIME-Version: 1.0
In-Reply-To: <90e8392d-5b18-6ce0-56ed-23dc6df606c7@gmail.com>
Content-Type: text/plain; charset=utf-8
Sender: linux-wireless-owner@vger.kernel.org
List-ID: <linux-wireless.vger.kernel.org>

On 19-5-2017 21:07, Heiner Kallweit wrote:
> Am 19.05.2017 um 20:03 schrieb Arend Van Spriel:
>> On 14-5-2017 13:45, Hans de Goede wrote:
>>> Hi,
>>>
>>> On 14-05-17 10:21, Arend Van Spriel wrote:
>>>> On 13-5-2017 16:55, Hans de Goede wrote:
>>>>> Hi,
>>>>>
>>>>> On 13-05-17 15:39, Heiner Kallweit wrote:
>>>>>> Am 13.05.2017 um 14:35 schrieb Hans de Goede:
>>>>>>> <resend with the author of the commit causing this added>
>>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> On 13-05-17 14:19, Hans de Goede wrote:
>>>>>>>> Hi,
>>>>>>>>
>>>>>>>> I've just rebased my personal kernel tree to what will soon be
>>>>>>>> 4.12-rc1
>>>>>>>> and I'm getting my dmesg log filled with the following errors:
>>>>>>>>
>>>>>>>> [   32.528271] brcmfmac: brcmf_sdio_rxglom: sublen 524 not multiple
>>>>>>>> of 8
>>>>>>>> [   32.528296] brcmfmac: brcmf_sdio_rxglom: sublen 84 not multiple
>>>>>>>> of 8
>>>>>>>> [   33.063241] brcmfmac: brcmf_sdio_rxglom: sublen 1492 not multiple
>>>>>>>> of 8
>>>>>>>>
>>>>>> After a brief look at the code I'm not sure that the check actually
>>>>>> checks
>>>>>> for an error condition. Apart from the error messages:
>>>>>> Do you face issues with the functionality of the driver?
>>>>>
>>>>> Yes after a while I get -ETIMEOUT errors for any sdio transfers
>>>>> to the device. But I'm not sure if this is caused by this commit,
>>>>> I think I've seen this once with 4.11 too.
>>>>>
>>>>> I've reverted the commit for now, but I'm fine with instead of
>>>>> doing the revert dropping the error check if the brcmfmac developers
>>>>> think that is ok. Currently the ETIMEOUT seems to be gone, so
>>>>> if dropping the revert causes it to re-appear then we know more.
>>>>
>>>> Instead of reverting please give this patch a try and let me know if it
>>>> works for you.
>>>>
>>>> Regards,
>>>> Arend
>>>> ---
>>>> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
>>>> b/drivers/n
>>>> index fc64b89..e034500 100644
>>>> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
>>>> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c
>>>> @@ -3422,7 +3422,7 @@ static int brcmf_sdio_bus_preinit(struct device
>>>> *dev)
>>>>                  /* otherwise, set txglomalign */
>>>>                  value = sdiodev->settings->bus.sdio.sd_sgentry_align;
>>>>                  /* SDIO ADMA requires at least 32 bit alignment */
>>>> -               value = max_t(u32, value, 4);
>>>> +               value = max_t(u32, value, ALIGNMENT);
>>>>                  err = brcmf_iovar_data_set(dev, "bus:txglomalign",
>>>> &value,
>>>>                                             sizeof(u32));
>>>>          }
>>>>
>>>
>>> I can confirm that the above fix fixes the messages.
>>
>> Heiner,
>>
>> Could I get your ack or even better your test verdict as well?
>>
> Unfortunately I don't have hardware to test this (as sdio isn't available
> on Odroid C2). However the patch looks logical and good to me.
> 
> I add Helmut as he gave his Tested-by for commit 5ef1ecf060f28e
> "mmc: sdio: fix alignment issue in struct sdio_func".
> Maybe he can test your patch as well.

Ok. Thanks,
Arend

> Rgds, Heiner
> 
>> Regards,
>> Arend
>>
>