Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:54100 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757205AbdELIzB (ORCPT ); Fri, 12 May 2017 04:55:01 -0400 From: Kalle Valo To: Arend van Spriel Cc: Xie Qirong , Franky Lin , Hante Meuleman , linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] brcmfmac: btcoex: replace init_timer with setup_timer References: <20170512073555.12333-1-cheerx1994@gmail.com> <87tw4qqyh1.fsf@kamboji.qca.qualcomm.com> Date: Fri, 12 May 2017 11:54:55 +0300 In-Reply-To: (Arend van Spriel's message of "Fri, 12 May 2017 10:36:56 +0200") Message-ID: <87d1beqwtc.fsf@kamboji.qca.qualcomm.com> (sfid-20170512_105530_155149_35A932AA) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org List-ID: Arend van Spriel writes: > On 5/12/2017 10:19 AM, Kalle Valo wrote: >> Xie Qirong writes: >> >>> The combination of init_timer and setting up the data and function field >>> manually is equivalent to calling setup_timer(). This is an api >>> consolidation only and improves readability. >>> >>> Acked-by: Arend van Spriel >>> Signed-off-by: Xie Qirong >>> --- >>> >>> setup_timer.cocci suggested the following improvement: >>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/btcoex.c:383:1-11: Use >>> setup_timer function for function on line 384. >>> >>> Patch was compile checked with: x86_64_defconfig + CONFIG_BRCMFMAC=y + >>> CONFIG_BRCMFMAC_USB=y + CONFIG_BRCMFMAC_PCIE=y + CONFIG_BRCM_TRACING=y + >>> CONFIG_BRCMDBG=y >>> >>> Kernel version: 4.11.0 (localversion-next is next-20170512) >> >> How is this different from the first version? >> >> https://patchwork.kernel.org/patch/9709467/ > > Hi Kalle, > > This is actually the third version. You are referring to the > not-specifically-named "v2" here, but how are you to know ;-) Exactly :) > This third version is the same as v1 on which I commented to put the > coccinelle output in the commit message. So I would still keep v2 if > nothing else changed in v3 apart from my Acked-by: tag. Ok, but I can easily take v3 (ie. this one) so that you get credit ;) -- Kalle Valo