Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:36930 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750749AbdFOQK1 (ORCPT ); Thu, 15 Jun 2017 12:10:27 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Subject: Re: [for-4.12] brcmfmac: fix brcmf_fws_add_interface() for USB devices From: Kalle Valo In-Reply-To: <1497268595-4836-1-git-send-email-arend.vanspriel@broadcom.com> References: <1497268595-4836-1-git-send-email-arend.vanspriel@broadcom.com> To: Arend Van Spriel Cc: linux-wireless@vger.kernel.org, Arend van Spriel Message-Id: <20170615161026.A794D60884@smtp.codeaurora.org> (sfid-20170615_181030_332548_8E23C4E4) Date: Thu, 15 Jun 2017 16:10:26 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org List-ID: Arend Van Spriel wrote: > USB devices rely on queuing functionality provided by the fwsignal > module regardless the mode fwsignal is operating in. For this some > data structure needs to be reserved which is tied to the interface, > which is done by brcmf_fws_add_interface(). However, it checks the > mode. Replace that by checking result from brcmf_fws_queue_skbs(). > Otherwise the driver will crash in a null pointer dereference when > data is transmitted on the interface. > > Fixes: fc0471e3e884 ("brcmfmac: ignore interfaces when fwsignal is disabled") > Reviewed-by: Franky Lin > Signed-off-by: Arend van Spriel Patch applied to wireless-drivers.git, thanks. a2b7a622d629 brcmfmac: fix brcmf_fws_add_interface() for USB devices -- https://patchwork.kernel.org/patch/9780809/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches