Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:50540 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750895AbdFAEQ0 (ORCPT ); Thu, 1 Jun 2017 00:16:26 -0400 From: Kalle Valo To: Jia-Ju Bai Cc: Larry Finger , linux-wireless@vger.kernel.org, b43-dev@lists.infradead.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] b43legacy: Fix a sleep-in-atomic bug in b43legacy_attr_interfmode_store References: <1496226547-5921-1-git-send-email-baijiaju1990@163.com> <85905124-7167-aeb0-8aff-4ceec09e9542@lwfinger.net> <592F6843.9000204@163.com> Date: Thu, 01 Jun 2017 07:15:51 +0300 In-Reply-To: <592F6843.9000204@163.com> (Jia-Ju Bai's message of "Thu, 01 Jun 2017 09:05:07 +0800") Message-ID: <87d1aomjgo.fsf@kamboji.qca.qualcomm.com> (sfid-20170601_061659_241161_84B0D0C1) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org List-ID: Jia-Ju Bai writes: >> Did you actually observe the attempt to sleep under the spin lock, >> or did you discover this using some tool? In other words, have >> either of your patches been tested? > > In fact, my reported bugs are found by a static analysis tool written > by me, and they are checked by my review of the driver code. It's valuable information to add to the commit log how you found the bug. If you check other wireless commits you can see comments like "Found by spatch", "Coverity reported" quite frequently. So I recommend that you also mention your tool in the commit log, makes understanding the background of the patch easier. -- Kalle Valo