Return-path: Received: from mail-qt0-f193.google.com ([209.85.216.193]:36470 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750728AbdFNOSk (ORCPT ); Wed, 14 Jun 2017 10:18:40 -0400 Received: by mail-qt0-f193.google.com with SMTP id s33so228644qtg.3 for ; Wed, 14 Jun 2017 07:18:39 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <878tkvos2v.fsf@purkki.adurom.net> References: <1496412785-8720-1-git-send-email-amit.karwar@redpinesignals.com> <1496412785-8720-7-git-send-email-amit.karwar@redpinesignals.com> <878tkvos2v.fsf@purkki.adurom.net> From: Amitkumar Karwar Date: Wed, 14 Jun 2017 19:48:38 +0530 Message-ID: (sfid-20170614_161843_726829_83918156) Subject: Re: [PATCH 6/6] rsi: add tx frame for common device configuration To: Kalle Valo Cc: linux-wireless@vger.kernel.org, Alexey Brodkin , Prameela Rani Garnepudi , Amitkumar Karwar Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, Jun 14, 2017 at 2:37 PM, Kalle Valo wrote: > Amitkumar Karwar writes: > >> From: Prameela Rani Garnepudi >> >> After successful loading of firmware, a CARD READY indication is >> received by host. Common device configuration parameters are sent >> to the device after this. It includes information like device >> operating mode (Wi-Fi alone or BT coex), power save related >> parameters, GPIO information etc. As device supports BT coex, >> this frame is send in COEX queue initially. Based on the operating >> mode, CARD READY indication is received from each protocol module >> in firmware i.e. WLAN, BT. >> >> Signed-off-by: Prameela Rani Garnepudi >> Signed-off-by: Amitkumar Karwar > > [...] > >> +static struct rsi_soc_gpio_vals unused_soc_gpio_bitmap = { >> + .pspi_csn_0 = USED_GPIO, //GPIO_0 >> + .pspi_csn_1 = USED_GPIO, //GPIO_1 >> + .host_wakeup_intr = USED_GPIO, //GPIO_2 >> + .pspi_data_0 = USED_GPIO, //GPIO_3 >> + .pspi_data_1 = USED_GPIO, //GPIO_4 >> + .pspi_data_2 = USED_GPIO, //GPIO_5 >> + .pspi_data_3 = USED_GPIO, //GPIO_6 >> + .i2c_scl = USED_GPIO, //GPIO_7 >> + .i2c_sda = USED_GPIO, //GPIO_8 >> + .uart1_rx = UNUSED_GPIO, //GPIO_9 >> + .uart1_tx = UNUSED_GPIO, //GPIO_10 >> + .uart1_rts_i2s_clk = UNUSED_GPIO, //GPIO_11 >> + .uart1_cts_i2s_ws = UNUSED_GPIO, //GPIO_12 >> + .dbg_uart_rx_i2s_din = UNUSED_GPIO, //GPIO_13 >> + .dbg_uart_tx_i2s_dout = UNUSED_GPIO, //GPIO_14 >> + .lp_wakeup_boot_bypass = UNUSED_GPIO, //GPIO_15 >> + .led_0 = USED_GPIO, //GPIO_16 >> + .btcoex_wlan_active_ext_pa_ant_sel_A = UNUSED_GPIO, //GPIO_17 >> + .btcoex_bt_priority_ext_pa_ant_sel_B = UNUSED_GPIO, //GPIO_18 >> + .btcoex_bt_active_ext_pa_on_off = UNUSED_GPIO, //GPIO_19 >> + .rf_reset = USED_GPIO, //GPIO_20 >> + .sleep_ind_from_device = UNUSED_GPIO, >> +}; > > No //, please. Use instead /* */. > Sure. I will take care of this Regards, Amitkumar