Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:54220 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751007AbdFUQjl (ORCPT ); Wed, 21 Jun 2017 12:39:41 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Subject: Re: rtlwifi: fix REG_USTIME_TSF register definition From: Kalle Valo In-Reply-To: <20170519150240.GA47825@ns.kevlo.org> References: <20170519150240.GA47825@ns.kevlo.org> To: Kevin Lo Cc: Larry Finger , Ping-Ke Shih , linux-wireless@vger.kernel.org Message-Id: <20170621152428.E3552607E4@smtp.codeaurora.org> (sfid-20170621_183947_273981_F87A6009) Date: Wed, 21 Jun 2017 15:24:28 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org List-ID: Kevin Lo wrote: > The REG_USTIME_TSF (US Time Tuning for TSF) definition of Realtek chips > should be 0x55C. > > Signed-off-by: Kevin Lo > > diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/reg.h b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/reg.h > index 15400ee6c04b..0c0d64aea651 100644 > --- a/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/reg.h > +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8188ee/reg.h > @@ -248,7 +248,6 @@ > #define REG_RD_NAV_NXT 0x0544 > #define REG_NAV_PROT_LEN 0x0546 > #define REG_BCN_CTRL 0x0550 > -#define REG_USTIME_TSF 0x0551 > #define REG_MBID_NUM 0x0552 > #define REG_DUAL_TSF_RST 0x0553 > #define REG_BCN_INTERVAL 0x0554 > @@ -256,6 +255,7 @@ > #define REG_DRVERLYINT 0x0558 > #define REG_BCNDMATIM 0x0559 > #define REG_ATIMWND 0x055A > +#define REG_USTIME_TSF 0x055C > #define REG_BCN_MAX_ERR 0x055D > #define REG_RXTSF_OFFSET_CCK 0x055E > #define REG_RXTSF_OFFSET_OFDM 0x055F > diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/reg.h b/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/reg.h > index 1bb7ed35812d..9e3b58a5d2bb 100644 > --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/reg.h > +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192ce/reg.h > @@ -227,7 +227,6 @@ > #define REG_RD_NAV_NXT 0x0544 > #define REG_NAV_PROT_LEN 0x0546 > #define REG_BCN_CTRL 0x0550 > -#define REG_USTIME_TSF 0x0551 > #define REG_MBID_NUM 0x0552 > #define REG_DUAL_TSF_RST 0x0553 > #define REG_BCN_INTERVAL 0x0554 > @@ -235,6 +234,7 @@ > #define REG_DRVERLYINT 0x0558 > #define REG_BCNDMATIM 0x0559 > #define REG_ATIMWND 0x055A > +#define REG_USTIME_TSF 0x055C > #define REG_BCN_MAX_ERR 0x055D > #define REG_RXTSF_OFFSET_CCK 0x055E > #define REG_RXTSF_OFFSET_OFDM 0x055F > diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/reg.h b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/reg.h > index b354b95936e2..d4c4e76a9244 100644 > --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192de/reg.h > +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192de/reg.h > @@ -255,7 +255,6 @@ > #define REG_RD_NAV_NXT 0x0544 > #define REG_NAV_PROT_LEN 0x0546 > #define REG_BCN_CTRL 0x0550 > -#define REG_USTIME_TSF 0x0551 > #define REG_MBID_NUM 0x0552 > #define REG_DUAL_TSF_RST 0x0553 > #define REG_BCN_INTERVAL 0x0554 > @@ -263,6 +262,7 @@ > #define REG_DRVERLYINT 0x0558 > #define REG_BCNDMATIM 0x0559 > #define REG_ATIMWND 0x055A > +#define REG_USTIME_TSF 0x055C > #define REG_BCN_MAX_ERR 0x055D > #define REG_RXTSF_OFFSET_CCK 0x055E > #define REG_RXTSF_OFFSET_OFDM 0x055F > diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/reg.h b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/reg.h > index 306059f9b9cc..30938cd9fce5 100644 > --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/reg.h > +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/reg.h > @@ -217,7 +217,6 @@ > #define REG_RD_NAV_NXT 0x0544 > #define REG_NAV_PROT_LEN 0x0546 > #define REG_BCN_CTRL 0x0550 > -#define REG_USTIME_TSF 0x0551 > #define REG_MBID_NUM 0x0552 > #define REG_DUAL_TSF_RST 0x0553 > #define REG_BCN_INTERVAL 0x0554 > @@ -225,6 +224,7 @@ > #define REG_DRVERLYINT 0x0558 > #define REG_BCNDMATIM 0x0559 > #define REG_ATIMWND 0x055A > +#define REG_USTIME_TSF 0x055C > #define REG_BCN_MAX_ERR 0x055D > #define REG_RXTSF_OFFSET_CCK 0x055E > #define REG_RXTSF_OFFSET_OFDM 0x055F > diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/reg.h b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/reg.h > index 03581d2a5da0..95c4f8e206c7 100644 > --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723be/reg.h > +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723be/reg.h > @@ -261,7 +261,6 @@ > #define REG_RD_NAV_NXT 0x0544 > #define REG_NAV_PROT_LEN 0x0546 > #define REG_BCN_CTRL 0x0550 > -#define REG_USTIME_TSF 0x0551 > #define REG_MBID_NUM 0x0552 > #define REG_DUAL_TSF_RST 0x0553 > #define REG_BCN_INTERVAL 0x0554 > @@ -269,6 +268,7 @@ > #define REG_DRVERLYINT 0x0558 > #define REG_BCNDMATIM 0x0559 > #define REG_ATIMWND 0x055A > +#define REG_USTIME_TSF 0x055C > #define REG_BCN_MAX_ERR 0x055D > #define REG_RXTSF_OFFSET_CCK 0x055E > #define REG_RXTSF_OFFSET_OFDM 0x055F > diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/reg.h b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/reg.h > index ed69dbe178ff..db8bc8a2de61 100644 > --- a/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/reg.h > +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8821ae/reg.h > @@ -267,7 +267,6 @@ > #define REG_RD_NAV_NXT 0x0544 > #define REG_NAV_PROT_LEN 0x0546 > #define REG_BCN_CTRL 0x0550 > -#define REG_USTIME_TSF 0x0551 > #define REG_MBID_NUM 0x0552 > #define REG_DUAL_TSF_RST 0x0553 > #define REG_BCN_INTERVAL 0x0554 > @@ -275,6 +274,7 @@ > #define REG_DRVERLYINT 0x0558 > #define REG_BCNDMATIM 0x0559 > #define REG_ATIMWND 0x055A > +#define REG_USTIME_TSF 0x055C > #define REG_BCN_MAX_ERR 0x055D > #define REG_RXTSF_OFFSET_CCK 0x055E > #define REG_RXTSF_OFFSET_OFDM 0x055F Patch applied to wireless-drivers-next.git, thanks. 9da96c5e7edd rtlwifi: fix REG_USTIME_TSF register definition -- https://patchwork.kernel.org/patch/9737421/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches