Return-path: Received: from mail-vk0-f68.google.com ([209.85.213.68]:35451 "EHLO mail-vk0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752169AbdGDMW5 (ORCPT ); Tue, 4 Jul 2017 08:22:57 -0400 Received: by mail-vk0-f68.google.com with SMTP id p193so12998665vkd.2 for ; Tue, 04 Jul 2017 05:22:57 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20170628123233.GA10039@symbol-HP-ZBook-15> References: <20170628123233.GA10039@symbol-HP-ZBook-15> From: Souptick Joarder Date: Tue, 4 Jul 2017 17:52:56 +0530 Message-ID: (sfid-20170704_142301_241876_DEA2A66B) Subject: Re: [PATCH] rtlwifi: Remove unused dummy function To: Larry Finger , Chaoming Li , Kalle Valo Cc: linux-wireless Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org List-ID: Any Comment for this patch ? On Wed, Jun 28, 2017 at 6:02 PM, Souptick Joarder wrote: > Removing unused dummy function > > Signed-off-by: Souptick Joarder > --- > drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c | 2 +- > drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c | 12 ------------ > drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.h | 3 --- > 3 files changed, 1 insertion(+), 16 deletions(-) > > diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c > index 96c923b..62d9214 100644 > --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c > +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/sw.c > @@ -173,7 +173,7 @@ static bool rtl92cu_get_btc_status(void) > .rx_urb_num = RTL92C_NUM_RX_URBS, > .rx_max_size = RTL92C_SIZE_MAX_RX_BUFFER, > .usb_rx_hdl = rtl8192cu_rx_hdl, > - .usb_rx_segregate_hdl = NULL, /* rtl8192c_rx_segregate_hdl; */ > + .usb_rx_segregate_hdl = NULL, > /* tx */ > .usb_tx_cleanup = rtl8192c_tx_cleanup, > .usb_tx_post_hdl = rtl8192c_tx_post_hdl, > diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c > index 41422e4..25a081c 100644 > --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c > +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.c > @@ -436,13 +436,6 @@ void rtl8192cu_rx_hdl(struct ieee80211_hw *hw, struct sk_buff * skb) > _rtl_rx_process(hw, skb); > } > > -void rtl8192c_rx_segregate_hdl( > - struct ieee80211_hw *hw, > - struct sk_buff *skb, > - struct sk_buff_head *skb_list) > -{ > -} > - > /*---------------------------------------------------------------------- > * > * Tx handler > @@ -675,8 +668,3 @@ void rtl92cu_tx_fill_cmddesc(struct ieee80211_hw *hw, > RT_PRINT_DATA(rtlpriv, COMP_CMD, DBG_LOUD, "H2C Tx Cmd Content", > pdesc, RTL_TX_DESC_SIZE); > } > - > -bool rtl92cu_cmd_send_packet(struct ieee80211_hw *hw, struct sk_buff *skb) > -{ > - return true; > -} > diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.h b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.h > index 487eec8..15a66c5 100644 > --- a/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.h > +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8192cu/trx.h > @@ -385,8 +385,6 @@ bool rtl92cu_rx_query_desc(struct ieee80211_hw *hw, > struct ieee80211_rx_status *rx_status, > u8 *p_desc, struct sk_buff *skb); > void rtl8192cu_rx_hdl(struct ieee80211_hw *hw, struct sk_buff * skb); > -void rtl8192c_rx_segregate_hdl(struct ieee80211_hw *, struct sk_buff *, > - struct sk_buff_head *); > void rtl8192c_tx_cleanup(struct ieee80211_hw *hw, struct sk_buff *skb); > int rtl8192c_tx_post_hdl(struct ieee80211_hw *hw, struct urb *urb, > struct sk_buff *skb); > @@ -404,6 +402,5 @@ void rtl92cu_fill_fake_txdesc(struct ieee80211_hw *hw, u8 * pDesc, > void rtl92cu_tx_fill_cmddesc(struct ieee80211_hw *hw, > u8 *pdesc, bool b_firstseg, > bool b_lastseg, struct sk_buff *skb); > -bool rtl92cu_cmd_send_packet(struct ieee80211_hw *hw, struct sk_buff *skb); > > #endif > -- > 1.9.1 >