Return-path: Received: from mga14.intel.com ([192.55.52.115]:34700 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751211AbdGPPRQ (ORCPT ); Sun, 16 Jul 2017 11:17:16 -0400 Date: Sun, 16 Jul 2017 23:16:53 +0800 From: kbuild test robot To: Ian Molton Cc: kbuild-all@01.org, linux-wireless@vger.kernel.org, arend.vanspriel@broadcom.com, franky.lin@broadcom.com, hante.meuleman@broadcom.com Subject: [PATCH] brcmfmac: fix boolreturn.cocci warnings Message-ID: <20170716151653.GA2109@lkp-wsx02> (sfid-20170716_171722_371702_C8CFCBD4) References: <201707162358.x6v6RcNt%fengguang.wu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20170716112129.10206-18-ian@mnementh.co.uk> Sender: linux-wireless-owner@vger.kernel.org List-ID: drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c:283:9-10: WARNING: return of 0/1 in function 'brcmf_chip_axi_iscoreup' with return type bool Return statements in functions returning bool should use true/false instead of 1/0. Generated by: scripts/coccinelle/misc/boolreturn.cocci Fixes: f9996a7ac81f ("brcmfmac: HUGE cleanup of IO access functions.") CC: Ian Molton Signed-off-by: Fengguang Wu --- chip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/chip.c @@ -280,7 +280,7 @@ static bool brcmf_chip_axi_iscoreup(stru val = brcmf_readl(ci, core->wrapbase + BCMA_IOCTL); if((val & BCMA_IOCTL_FGC) || !(val & BCMA_IOCTL_CLK)) - return 0; + return false; /* Is core in reset? */ val = brcmf_readl(ci, core->wrapbase + BCMA_RESET_CTL);