Return-path: Received: from muru.com ([72.249.23.125]:53252 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752131AbdGDITV (ORCPT ); Tue, 4 Jul 2017 04:19:21 -0400 Date: Tue, 4 Jul 2017 01:19:18 -0700 From: Tony Lindgren To: "Reizer, Eyal" Cc: Kalle Valo , "linux-wireless@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [v2] wlcore: add missing nvs file name info for wilink8 Message-ID: <20170704081917.GI3730@atomide.com> (sfid-20170704_101954_086034_9C79CB5B) References: <8665E2433BC68541A24DFFCA87B70F5B363E2669@DFRE01.ent.ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <8665E2433BC68541A24DFFCA87B70F5B363E2669@DFRE01.ent.ti.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: * Reizer, Eyal [170703 23:58]: > When working with wl18xx the nvs file is used for defining an alternate > mac address and override the default mac address that is stored inside > the wl18xx chip. > > The following commits: > c815fde wlcore: spi: Populate config firmware data > d776fc8 wlcore: sdio: Populate config firmware data > > Populated the nvs entry for wilink6 and wilink7 only while it is > still needed for wilink8 as well. > This broke user space backward compatibility when upgrading from older > kernels, as the alternate mac address would not be read from the nvs that is > already present in the file system (lib/firmware/ti-connectivity/wl1271-nvs.bin) > causing mac address change of the wlan interface. > > This patch fix this and update the structure field with the same default nvs file > name that has been used before. I think more checks on the nvs file being used are needed to avoid other nasty issues, see the comments I just made in the earlier version of this patch. Regards, Tony