Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:50966 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752203AbdHCKBL (ORCPT ); Thu, 3 Aug 2017 06:01:11 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Subject: Re: qtnfmac: Tidy up DMA mask setting From: Kalle Valo In-Reply-To: <2c3f47792b2e38d5584d641d98e82f8318fefc72.1500917445.git.robin.murphy@arm.com> References: <2c3f47792b2e38d5584d641d98e82f8318fefc72.1500917445.git.robin.murphy@arm.com> To: Robin Murphy Cc: imitsyanko@quantenna.com, avinashp@quantenna.com, smatyukevich@quantenna.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Message-Id: <20170803100110.A8D2D6087E@smtp.codeaurora.org> (sfid-20170803_120125_620308_24D06388) Date: Thu, 3 Aug 2017 10:01:08 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org List-ID: Robin Murphy wrote: > As the only caller of dma_supported() outside of DMA API internals, the > qtfnmac driver stands out and invites scrutiny. Thankfully, it's not > being used for evil, but it is entirely redundant, since it open-codes a > check that the DMA mask setting functions are going to perform anyway. > In fact, the whole qtnf_pcie_init_dma_mask() function is nothing more > than a rather long-winded implementation of dma_set_mask_and_coherent(), > so let's just use that directly. > > Signed-off-by: Robin Murphy > Acked-by: Sergey Matyukevich Patch applied to wireless-drivers-next.git, thanks. 13cb8a5845ff qtnfmac: Tidy up DMA mask setting -- https://patchwork.kernel.org/patch/9859961/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches