Return-path: Received: from mx1.redhat.com ([209.132.183.28]:57556 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751160AbdHNRZi (ORCPT ); Mon, 14 Aug 2017 13:25:38 -0400 Subject: Re: [4.13 REGRESSION] Re: brcm43430 sdio wifi regression with 4.13-rc1 To: Kalle Valo Cc: Arend van Spriel , Ian Molton , russianneuromancer , linux-wireless , brcm80211-dev-list.pdl@broadcom.com References: <03779c4f-b48b-444f-59c5-e10324dc77bd@mnementh.co.uk> <04f1050f-966e-b0c8-7714-ee5065ba69cf@mnementh.co.uk> <9e616361-da87-6f46-8ee3-4a4f673c3c80@broadcom.com> <2323972d-280f-048f-31fb-1c31b0228b22@redhat.com> <87d17yb195.fsf@kamboji.qca.qualcomm.com> From: Hans de Goede Message-ID: <3abe4265-fd1c-4f1b-a416-429b8062856f@redhat.com> (sfid-20170814_192543_850372_0561FA1C) Date: Mon, 14 Aug 2017 19:25:35 +0200 MIME-Version: 1.0 In-Reply-To: <87d17yb195.fsf@kamboji.qca.qualcomm.com> Content-Type: text/plain; charset=utf-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi, On 14-08-17 17:46, Kalle Valo wrote: > Hans de Goede writes: > >>>> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c >>>> b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c >>>> index d21258d..def120c 100644 >>>> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c >>>> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/feature.c >>>> @@ -159,8 +159,9 @@ void brcmf_feat_attach(struct brcmf_pub *drvr) >>>> >>>> brcmf_feat_firmware_capabilities(ifp); >>>> memset(&gscan_cfg, 0, sizeof(gscan_cfg)); >>>> - brcmf_feat_iovar_data_set(ifp, BRCMF_FEAT_GSCAN, "pfn_gscan_cfg", >>>> - &gscan_cfg, sizeof(gscan_cfg)); >>>> + if (drvr->bus_if->chip != BRCM_CC_43430_CHIP_ID) >>>> + brcmf_feat_iovar_data_set(ifp, BRCMF_FEAT_GSCAN, >>>> "pfn_gscan_cfg", >>>> + &gscan_cfg, sizeof(gscan_cfg)); >>>> brcmf_feat_iovar_int_get(ifp, BRCMF_FEAT_PNO, "pfn"); >>>> if (drvr->bus_if->wowl_supported) >>>> brcmf_feat_iovar_int_get(ifp, BRCMF_FEAT_WOWL, "wowl"); >>>> >> >> AFAICT this is still a problem with 4.13-rc5, can we at least get >> the above workaround merged for 4.13 ? > > Just applied it few hours ago: > > https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers.git/commit/?id=e9bf53ab1ee34bb05c104bbfd2b77c844773f8e6 > > I'll try to get it to -rc6 but of course it depends on pull schedules if > it makes it or not. Ok, thank you. Regards, Hans