Return-path: Received: from mail-qt0-f174.google.com ([209.85.216.174]:36028 "EHLO mail-qt0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750849AbdHHJpm (ORCPT ); Tue, 8 Aug 2017 05:45:42 -0400 Received: by mail-qt0-f174.google.com with SMTP id v29so16699929qtv.3 for ; Tue, 08 Aug 2017 02:45:41 -0700 (PDT) From: Sven Eckelmann To: linux-wireless@vger.kernel.org Cc: Kalle Valo , "Luis R. Rodriguez" , ath10k@lists.infradead.org Subject: ath: Incorrect regDomainPairs/allCountries settings Date: Tue, 08 Aug 2017 11:45:38 +0200 Message-ID: <1693831.JqVThioVz9@bentobox> (sfid-20170808_114546_349576_0BB4D63B) MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi, I just had two inquiries from Vietnam and Singapore regarding the used CTL limits by Atheros based chips. I've checked through the code and noticed that regd_common.h assigns SG to APL6_WORLD and VN to NULL1_WORLD. * SG: APL6_WORLD - 2.4GHz: CTL_ETSI - 5GHz: CTL_ETSI * VN: NULL1_WORLD - 2.4GHz: CTL_ETSI - 5GHz: NO_CTL But I personally would have expected that both countries would be assigned to FCC3_WORLD. * FCC3_WORLD - 2.4GHz: CTL_ETSI - 5GHz: CTL_FCC Maybe someone from QCA can check with their internal driver. I have compared the current ath/regd_common.h with what I would have expected (which might not be correct after all). I still wanted to list the things which I found: Missing Entries in CountryCode (regd.h): * CTRY_AFGHANISTAN = 4, * CTRY_AMERICAN_SAMOA = 16, * CTRY_ANGUILLA = 660, * CTRY_BAHAMAS = 44, * CTRY_BERMUDA = 60, * CTRY_BHUTAN = 64, * CTRY_BURKINA_FASO = 854, * CTRY_CAYMAN_ISLANDS = 136, * CTRY_CENTRAL_AFRICA_REPUBLIC = 140, * CTRY_CHAD = 148, * CTRY_CHRISTMAS_ISLAND = 162, * CTRY_DOMINICA = 212, * CTRY_ETHIOPIA = 231, * CTRY_FRENCH_GUIANA = 254, * CTRY_FRENCH_POLYNESIA = 258, * CTRY_GHANA = 288, * CTRY_GUADELOUPE = 312, * CTRY_GUYANA = 328, * CTRY_COTE_D_IVOIRE = 384, * CTRY_LESOTHO = 426, * CTRY_MALAWI = 454, * CTRY_MALDIVES = 462, * CTRY_MARSHALL_ISLANDS = 584, * CTRY_MARTINIQUE = 474, * CTRY_MAURITANIA = 478, * CTRY_MAURITIUS = 480, * CTRY_MAYOTTE = 175, * CTRY_MICRONESIA = 583, * CTRY_MOLDOVA = 498, * CTRY_MONGOLIA = 496, * CTRY_NAMIBIA = 516, * CTRY_NIGERIA = 566, * CTRY_NORTHERN_MARIANA_ISLANDS = 580, * CTRY_PALAU = 585, * CTRY_REUNION = 638, * CTRY_RWANDA = 646, * CTRY_ST_BARTHELEMY = 652, * CTRY_ST_KITTS_NEVIS = 659, * CTRY_ST_LUCIA = 662, * CTRY_ST_MARTIN = 663, * CTRY_ST_PIERRE_MIQUELON = 666, * CTRY_ST_VINCENT_GRENADIENS= 670, * CTRY_SAMOA = 882, * CTRY_SENEGAL = 686, * CTRY_SERBIA = 688, * CTRY_MONTENEGRO = 499, * CTRY_SURINAME = 740, * CTRY_TANZANIA = 834, * CTRY_TOGO = 768, * CTRY_TURKS_CAICOS = 796, * CTRY_UGANDA = 800, * CTRY_UNITED_STATES2 = 841, * CTRY_UNITED_STATES3 = 843, * CTRY_VANUATU = 548, * CTRY_VIRGIN_ISLANDS = 850, * CTRY_WALLIS_FUTUNA = 876, * CTRY_ARGENTINA2 = 5003 Entries which most likely shouldn't exist in CountryCode: * CTRY_KOREA_ROC2 * CTRY_SERBIA_MONTENEGRO Things which I missed in the EnumRd: * FCC11_WORLD = 0x19, * FCC3_ETSIC = 0x3F, * ETSI8_WORLD = 0x3D, * ETSI9_WORLD = 0x3E, * APL12_WORLD = 0x51, * APL14_WORLD = 0x57, * APL15_WORLD = 0x59, * APL13_WORLD = 0x5A, * APL10_WORLD = 0x5F, The new mappings in regDomainPairs for the used EnumRds would then be: * {FCC11_WORLD, CTL_FCC, CTL_ETSI}, * {FCC3_ETSIC, CTL_FCC, CTL_ETSI}, * {ETSI8_WORLD, CTL_ETSI, CTL_ETSI}, * {ETSI9_WORLD, CTL_ETSI, CTL_ETSI}, * {APL10_WORLD, CTL_ETSI, CTL_ETSI}, * {APL12_WORLD, CTL_ETSI, CTL_ETSI}, * {APL13_WORLD, CTL_ETSI, CTL_ETSI}, * {APL14_WORLD, CTL_FCC, CTL_ETSI}, * {APL15_WORLD, CTL_FCC, CTL_ETSI}, Things which I missed in allCountries * {CTRY_AFGHANISTAN, ETSI1_WORLD, "AF"}, * {CTRY_AMERICAN_SAMOA, FCC3_FCCA, "AS"}, * {CTRY_ANGUILLA, ETSI1_WORLD, "AI"}, * {CTRY_BAHAMAS, FCC3_WORLD, "BS"}, * {CTRY_BERMUDA, FCC3_FCCA, "BM"}, * {CTRY_BHUTAN, ETSI1_WORLD, "BT"}, * {CTRY_BURKINA_FASO,FCC3_WORLD, "BF"}, * {CTRY_CAYMAN_ISLANDS, FCC3_WORLD, "KY"}, * {CTRY_CENTRAL_AFRICA_REPUBLIC, FCC3_WORLD, "CF"}, * {CTRY_CHAD, ETSI1_WORLD, "TD"}, * {CTRY_CHRISTMAS_ISLAND, FCC3_WORLD, "CX"}, * {CTRY_DOMINICA, FCC1_FCCA, "DM"}, * {CTRY_ETHIOPIA, ETSI1_WORLD, "ET"}, * {CTRY_FRENCH_GUIANA, ETSI1_WORLD, "GF"}, * {CTRY_FRENCH_POLYNESIA, ETSI1_WORLD, "PF"}, * {CTRY_GHANA, FCC3_WORLD, "GH"}, * {CTRY_GUADELOUPE, ETSI1_WORLD, "GP"}, * {CTRY_GUYANA, APL1_ETSIC, "GY"}, * {CTRY_COTE_D_IVOIRE, FCC3_WORLD, "CI"}, * {CTRY_KENYA, APL12_WORLD, "KE"}, * {CTRY_LESOTHO, ETSI1_WORLD, "LS"}, * {CTRY_MALDIVES, APL6_WORLD, "MV"}, * {CTRY_MARSHALL_ISLANDS, FCC3_FCCA, "MH"}, * {CTRY_MARTINIQUE, ETSI1_WORLD, "MQ"}, * {CTRY_MAURITANIA, ETSI1_WORLD, "MR"}, * {CTRY_MAURITIUS, FCC3_WORLD, "MU"}, * {CTRY_MAYOTTE, ETSI1_WORLD, "YT"}, * {CTRY_MICRONESIA, FCC3_FCCA, "FM"}, * {CTRY_MOLDOVA, ETSI1_WORLD, "MD"}, * {CTRY_MONGOLIA, FCC3_WORLD, "MN"}, * {CTRY_MONTENEGRO, ETSI1_WORLD, "ME"}, * {CTRY_NAMIBIA, APL9_WORLD, "NA"}, * {CTRY_NICARAGUA, FCC3_FCCA, "NI"}, * {CTRY_NIGERIA, APL8_WORLD, "NG"}, * {CTRY_NORTHERN_MARIANA_ISLANDS, FCC3_FCCA, "MP"}, * {CTRY_PALAU, FCC3_FCCA, "PW"}, * {CTRY_PARAGUAY, FCC3_WORLD, "PY"}, * {CTRY_REUNION, ETSI1_WORLD, "RE"}, * {CTRY_RWANDA, FCC3_WORLD, "RW"}, * {CTRY_SENEGAL, FCC3_WORLD, "SN"}, * {CTRY_SERBIA, ETSI1_WORLD, "RS"}, * {CTRY_ST_BARTHELEMY, ETSI1_WORLD, "BL"}, * {CTRY_ST_KITTS_NEVIS, APL10_WORLD, "KN"}, * {CTRY_ST_LUCIA, APL10_WORLD, "LC"}, * {CTRY_ST_MARTIN, ETSI1_WORLD, "MF"}, * {CTRY_ST_PIERRE_MIQUELON, ETSI1_WORLD, "PM"}, * {CTRY_ST_VINCENT_GRENADIENS, ETSI1_WORLD, "VC"}, * {CTRY_SAMOA, ETSI1_WORLD, "WS"}, * {CTRY_SURINAME, ETSI1_WORLD, "SR"}, * {CTRY_TANZANIA, APL1_WORLD, "TZ"}, * {CTRY_TOGO, ETSI1_WORLD, "TG"}, * {CTRY_TURKS_CAICOS, FCC3_WORLD, "TC"}, * {CTRY_UGANDA, FCC3_WORLD, "UG"}, * {CTRY_VANUATU, FCC3_WORLD, "VU"}, * {CTRY_VIRGIN_ISLANDS, FCC3_FCCA, "VI"}, * {CTRY_WALLIS_FUTUNA, ETSI1_WORLD, "WF"}, Things which seemed to be "wrong" in allCountries: * CTRY_ALBANIA: NULL1_WORLD -> ETSI1_WORLD - changes 5GHz to CTL_ETSI * CTRY_ALGERIA: NULL1_WORLD -> APL13_WORLD - changes 5GHz to CTL_ETSI * CTRY_AUSTRALIA: FCC2_WORLD -> FCC3_WORLD * CTRY_BAHRAIN: APL6_WORLD -> APL15_WORLD - changes 5GHz to CTL_ETSI * CTRY_BANGLADESH: NULL1_WORLD -> APL1_WORLD - changes 5GHz to CTL_FCC * CTRY_BOLIVIA: APL1_ETSIC -> APL8_WORLD - changes 5GHz to CTL_FCC * CTRY_BRAZIL: FCC3_WORLD -> FCC3_ETSIC * CTRY_BRUNEI_DARUSSALAM: APL1_WORLD -> APL6_WORLD - changes 5GHz to CTL_FCC * CTRY_BULGARIA: ETSI6_WORLD -> ETSI1_WORLD * CTRY_CHINA: APL1_WORLD -> APL14_WORLD * CTRY_COLOMBIA: FCC1_FCCA -> FCC3_WORLD - changes 2.4GHz to CTL_ETSI * CTRY_COSTA_RICA: FCC1_WORLD -> FCC3_WORLD * CTRY_CZECH: ETSI3_WORLD -> ETSI1_WORLD * CTRY_ECUADOR: FCC1_WORLD -> FCC3_WORLD * CTRY_GUAM: FCC1_FCCA -> FCC3_FCCA * CTRY_GUATEMALA: FCC1_FCCA -> ETSI1_WORLD - changes 2.4GHz to CTL_ETSI - changes 5GHz to CTL_ETSI * CTRY_HAITI: ETSI1_WORLD -> FCC3_FCCA - changes 2.4GHz to CTL_FCC - changes 5GHz to CTL_FCC * CTRY_HONDURAS: NULL1_WORLD -> FCC3_WORLD - changes 5GHz to CTL_FCC * CTRY_INDIA: APL6_WORLD -> APL15_WORLD - changes 5GHz to CTL_ETSI * CTRY_INDONESIA: NULL1_WORLD -> APL2_ETSIC - changes 5GHz to CTL_FCC * CTRY_ISRAEL: NULL1_WORLD -> ETSI3_WORLD - changes 5GHz to CTL_ETSI * CTRY_JORDAN: ETSI2_WORLD -> APL4_WORLD - changes 5GHz to CTL_ETSI * CTRY_LEBANON: NULL1_WORLD -> FCC3_WORLD - changes 5GHz to CTL_FCC * CTRY_MACAU: FCC2_WORLD -> FCC3_WORLD * CTRY_MACEDONIA: NULL1_WORLD -> ETSI1_WORLD - changes 5GHz to CTL_ETSI * CTRY_MALAYSIA: APL8_WORLD -> FCC11_WORLD - changes 5GHz to CTL_FCC * CTRY_MEXICO: FCC1_FCCA -> FCC3_ETSIC - changes 2.4GHz to CTL_FCC * CTRY_MONACO: ETSI4_WORLD -> ETSI1_WORLD * CTRY_MOROCCO: APL4_WORLD -> ETSI3_WORLD - changes 5GHz to CTL_FCC * CTRY_NEPAL: APL1_WORLD -> APL6_WORLD - changes 5GHz to CTL_FCC * CTRY_NEW_ZEALAND: FCC2_ETSIC -> FCC3_ETSIC * CTRY_OMAN: FCC3_WORLD -> ETSI1_WORLD - changes 5GHz to CTL_ETSI * CTRY_PAKISTAN: NULL1_WORLD -> APL1_ETSIC - changes 5GHz to CTL_FCC * CTRY_PAPUA_NEW_GUINEA: FCC1_WORLD -> FCC3_WORLD * CTRY_PERU: APL1_WORLD -> FCC3_WORLD * CTRY_PHILIPPINES: APL1_WORLD -> FCC3_WORLD * CTRY_PUERTO_RICO: FCC1_FCCA -> FCC3_FCCA * CTRY_ROMANIA: NULL1_WORLD -> ETSI1_WORLD - changes 5GHz to CTL_ETSI * CTRY_RUSSIA: NULL1_WORLD -> ETSI8_WORLD * CTRY_SAUDI_ARABIA: NULL1_WORLD -> ETSI1_WORLD - changes 5GHz to CTL_ETSI * CTRY_SINGAPORE: APL6_WORLD -> FCC3_WORLD - changes 5GHz to CTL_ETSI * CTRY_TAIWAN: APL3_FCCA -> FCC3_FCCA * CTRY_TURKEY: ETSI3_WORLD -> ETSI1_WORLD * CTRY_UKRAINE: NULL1_WORLD -> ETSI9_WORLD - changes 5GHz to CTL_ETSI * CTRY_UAE: NULL1_WORLD -> FCC3_WORLD - changes 5GHz to CTL_FCC * CTRY_URUGUAY: FCC3_WORLD -> FCC2_WORLD * CTRY_UZBEKISTAN: FCC3_FCCA -> ETSI3_WORLD - changes 2.4GHz to CTL_ETSI - changes 5GHz to CTL_ETSI * CTRY_VENEZUELA: APL2_ETSIC -> FCC2_ETSIC * CTRY_VIET_NAM: NULL1_WORLD -> FCC3_WORLD - changes 5GHz to CTL_FCC * CTRY_ZIMBABWE: NULL1_WORLD -> ETSI1_WORLD - changes 5GHz to CTL_ETSI Not existing countries in allCountries: * CTRY_SERBIA_MONTENEGRO Kind regards, Sven