Return-path: Received: from mail-qk0-f193.google.com ([209.85.220.193]:37987 "EHLO mail-qk0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750827AbdHPGlM (ORCPT ); Wed, 16 Aug 2017 02:41:12 -0400 Received: by mail-qk0-f193.google.com with SMTP id m84so2603072qki.5 for ; Tue, 15 Aug 2017 23:41:12 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <416d9508-0cd2-24d5-420d-7002c1882202@broadcom.com> References: <1502458889-9690-1-git-send-email-amitkarwar@gmail.com> <1502458889-9690-6-git-send-email-amitkarwar@gmail.com> <87k226da0d.fsf@kamboji.qca.qualcomm.com> <416d9508-0cd2-24d5-420d-7002c1882202@broadcom.com> From: Prameela Rani Garnepudi Date: Wed, 16 Aug 2017 12:11:11 +0530 Message-ID: (sfid-20170816_084116_158817_34734E95) Subject: Re: [PATCH 05/11] rsi: handle station connection in AP mode To: Arend van Spriel Cc: Kalle Valo , Amitkumar Karwar , linux-wireless@vger.kernel.org, Amitkumar Karwar Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, Aug 15, 2017 at 12:40 AM, Arend van Spriel wrote: > On 14-08-17 08:53, Prameela Rani Garnepudi wrote: >> >> Hi Kalle, >> >> I will change the debug level and send the updated patches again. >> >> Thanks, >> Prameela > > > Please do not top-post. Yeah, thanks. I will take care of this for all my replies from now on wards. > >> On Mon, Aug 14, 2017 at 10:24 AM, Kalle Valo wrote: >>> >>> Amitkumar Karwar writes: >>> >>>> From: Prameela Rani Garnepudi >>>> >>>> Station structures are maintained in driver with required >>>> fields. When mac80211 callback sta_add is called, driver >>>> iterates through list of connected stations to check available >>>> index and assigns station id which is important for further >>>> communication to that station. Then peer notify frame is send >>>> to firmware to inform the firmware about new station connection. >>>> >>>> Signed-off-by: Prameela Rani Garnepudi >>>> Signed-off-by: Amitkumar Karwar >>> >>> >>> [...] >>> >>>> @@ -1157,18 +1159,81 @@ static int rsi_mac80211_sta_add(struct >>>> ieee80211_hw *hw, >>>> { >>>> struct rsi_hw *adapter = hw->priv; >>>> struct rsi_common *common = adapter->priv; >>>> + bool sta_exist = false; >>>> + struct rsi_sta *rsta; >>>> + >>>> + print_hex_dump(KERN_INFO, "Station add: ", DUMP_PREFIX_OFFSET, >>>> + 16, 1, sta->addr, ETH_ALEN, 0); >>> >>> >>> The driver should not spam the logs every time a client connects, so >>> this should be a debug message. > > > I am wondering why print_hex_dump() is used for printing the station mac > address. Just use: pr_debug("Station add: %pM\n", sta->addr); Yeah. Got the point, thanks. I will use 'rsi' macro 'rsi_dbg' for this debug message with this format specifier '%pM'. > > Regards, > Arend -- G. Prameela Rani (M.Tech,CSE)