Return-path: Received: from smtp1.cypress.com ([157.95.67.100]:50059 "EHLO smtp1.cypress.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751727AbdHBDze (ORCPT ); Tue, 1 Aug 2017 23:55:34 -0400 Subject: Re: [PATCH 1/3] brcmfmac: set wpa_auth to WPA_AUTH_DISABLED in AP/opensecurity mode To: Arend van Spriel , franky.lin@broadcom.com, hante.meuleman@broadcom.com, kvalo@codeaurora.org Cc: linux-wireless@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com References: <1501577287-28904-1-git-send-email-wright.feng@cypress.com> From: Wright Feng Message-ID: <781c75de-dc99-0ac7-bb93-b55ebc75a952@cypress.com> (sfid-20170802_055537_533693_7DD95A2D) Date: Wed, 2 Aug 2017 10:56:02 +0800 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 2017/8/1 下午 08:41, Arend van Spriel wrote: > On 01-08-17 10:48, Wright Feng wrote: >> When setting wpa_auth to WPA_AUTH_NONE(1) in AP mode with WEP secuirty, >> firmware will set privacy bit and add WPA OUI in VENDOR IE in beacon and >> probe response. It confuses the supplicant in sation client by the >> security type from softAP beacon and we will see [WPA-?] in scan result. >> So we set WPA_AUTH_DISABLED in softAP mode with opensecurity. >> >> Signed-off-by: Wright Feng >> --- >> drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c | 7 ++++++- >> 1 file changed, 6 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c >> index a31ea10..54588d2 100644 >> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c >> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/cfg80211.c >> @@ -3854,6 +3854,7 @@ static s32 brcmf_cfg80211_suspend(struct wiphy *wiphy, >> static s32 brcmf_configure_opensecurity(struct brcmf_if *ifp) >> { >> s32 err; >> + s32 wpa_val; >> >> /* set auth */ >> err = brcmf_fil_bsscfg_int_set(ifp, "auth", 0); >> @@ -3868,7 +3869,11 @@ static s32 brcmf_configure_opensecurity(struct brcmf_if *ifp) >> return err; >> } >> /* set upper-layer auth */ >> - err = brcmf_fil_bsscfg_int_set(ifp, "wpa_auth", WPA_AUTH_NONE); >> + if (brcmf_is_ibssmode(ifp->vif)) >> + wpa_val = WPA_AUTH_NONE; >> + else >> + wpa_val = WPA_AUTH_DISABLED; >> + err = brcmf_fil_bsscfg_int_set(ifp, "wpa_auth", wpa_val); > > Is WPA_AUTH_NONE ok for IBSS mode? Not sure why it is handled > differently. Is it because you do not want to change things for IBSS > mode as you did not try that? I would like to keep WPA_AUTH_NODE for IBSS mode because the comment of WPA_AUTH_NONE definition in brcmu_wifi.h is "none (IBSS)". It seems that WPA_AUTH_NONE is for IBSS mode. > > Regards, > Arend >