Return-path: Received: from mail-oi0-f68.google.com ([209.85.218.68]:37850 "EHLO mail-oi0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752370AbdHXOl0 (ORCPT ); Thu, 24 Aug 2017 10:41:26 -0400 Subject: Re: Two rtlwifi drivers? To: Kalle Valo , Dan Carpenter , Greg Kroah-Hartman , Ping-Ke Shih , Yan-Hsuan Chuang , Johannes Berg , Souptick Joarder , devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20170824100832.lcmbwcjhzwlgozeh@mwanda> <87h8wxw4bq.fsf@kamboji.qca.qualcomm.com> From: Larry Finger Message-ID: <652d42ad-a077-530b-743f-d38ddf3ff677@lwfinger.net> (sfid-20170824_164131_040188_7C9E9E42) Date: Thu, 24 Aug 2017 09:41:24 -0500 MIME-Version: 1.0 In-Reply-To: <87h8wxw4bq.fsf@kamboji.qca.qualcomm.com> Content-Type: text/plain; charset=utf-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 08/24/2017 07:14 AM, Kalle Valo wrote: > Dan Carpenter writes: > >> Smatch is distrustful of the "capab" value and marks it as user >> controlled. I think it actually comes from the firmware? Anyway, I >> looked at other drivers and they added a bounds check and it seems like >> a harmless thing to have so I have added it here as well. >> >> Signed-off-by: Dan Carpenter >> >> diff --git a/drivers/staging/rtlwifi/base.c b/drivers/staging/rtlwifi/base.c >> index f7f207cbaee3..a30b928d5ee1 100644 >> --- a/drivers/staging/rtlwifi/base.c >> +++ b/drivers/staging/rtlwifi/base.c > > I'm getting slightly annoyed that we now apparently have two duplicate > rtlwifi drivers (with the same name!) and I'm being spammed by staging > patches. Was this really a smart thing to do? And what will be the > future of these two drivers? > > (Of course this is not directed to Dan, he is just fixing bugs found by > smatch, but more like a general question.) That was the decision that you and Greg made. The version in wireless-drivers needs many patches to handle the new device. The progress in applying these to wireless-drivers was very slow for many reasons. Keeping a single version of that code would have required coordination between you and Greg, which was discouraged. The future, as stated in the TODO in staging, is to merge all the changes in the support drivers into wireless-drivers, and then move the new RTL8822BE driver out of staging. I'm sorry about the fallout affecting you, and I probably should have changed the directory names. In any case, ignore any patches that belong in staging. If I see any that do not include GregKH in the "To" list, I will NACK them and request proper routing. Larry