Return-path: Received: from mail-by2nam01on0087.outbound.protection.outlook.com ([104.47.34.87]:57632 "EHLO NAM01-BY2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751425AbdH3CNk (ORCPT ); Tue, 29 Aug 2017 22:13:40 -0400 Subject: Re: [PATCH 3/5] qtnfmac: modify qtnf_map_bar not to return NULL To: Sergey Matyukevich Cc: linux-wireless@vger.kernel.org, Avinash Patil References: <20170829121623.24761-1-sergey.matyukevich.os@quantenna.com> <20170829121623.24761-4-sergey.matyukevich.os@quantenna.com> From: Igor Mitsyanko Message-ID: (sfid-20170830_041344_685201_CC4BA538) Date: Tue, 29 Aug 2017 19:13:35 -0700 MIME-Version: 1.0 In-Reply-To: <20170829121623.24761-4-sergey.matyukevich.os@quantenna.com> Content-Type: text/plain; charset=utf-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 08/29/2017 05:16 AM, Sergey Matyukevich wrote: > NULL is not a special type of success here but a error pointer. > So it makes sense to check against NULL in qtnf_map_bar > and return error code. > > Signed-off-by: Sergey Matyukevich > --- On a first glance not immediately obvious what is logically changed here, is it so that pr_debug() would not print NULL pointer?