Return-path: Received: from mail-qt0-f178.google.com ([209.85.216.178]:34906 "EHLO mail-qt0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753953AbdIDUk0 (ORCPT ); Mon, 4 Sep 2017 16:40:26 -0400 Received: by mail-qt0-f178.google.com with SMTP id k2so5708519qte.2 for ; Mon, 04 Sep 2017 13:40:26 -0700 (PDT) Subject: Re: [PATCH v2] brcmfmac: Correctly fail to suspend when SDIO does not support power on suspend To: Steve deRosier Cc: Eric Bentley , Kalle Valo , "linux-wireless@vger.kernel.org" References: From: Arend van Spriel Message-ID: (sfid-20170904_224030_593316_B6095EAF) Date: Mon, 4 Sep 2017 22:40:23 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 04-09-17 21:33, Steve deRosier wrote: > On Fri, Sep 1, 2017 at 1:02 PM, Arend van Spriel > wrote: >> Also note that the wifi chip (the term "radio" does not quite cover it) has >> not really lost power. It is quite common that it is not powered through the >> SDIO bus. With the power-sequence support in the MMC stack these days the >> suspend may result in loss of power. Otherwise, it is just the bus that >> loses power (and clock) and the flags affect what tricks the MMC stack tries >> to pull to get the device accessible again upon resume. >> > Arend, > > Indeed - I'm familiar with the platform that Eric is using and it is > exactly as you say: the chip is powered externally. There's some > platform issues here that need to be resolved in addition, but the > change to brcmfmac stands alone OK. Sure thing. I was not arguing the fix itself. Just wanted to clarify the terms used in the commit message. Regards, Arend