Return-path: Received: from mail-ua0-f171.google.com ([209.85.217.171]:33734 "EHLO mail-ua0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753994AbdIDTdb (ORCPT ); Mon, 4 Sep 2017 15:33:31 -0400 Received: by mail-ua0-f171.google.com with SMTP id g47so3583553uad.0 for ; Mon, 04 Sep 2017 12:33:31 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: References: From: Steve deRosier Date: Mon, 4 Sep 2017 12:33:30 -0700 Message-ID: (sfid-20170904_213334_838322_DFE1131F) Subject: Re: [PATCH v2] brcmfmac: Correctly fail to suspend when SDIO does not support power on suspend To: Arend van Spriel Cc: Eric Bentley , Kalle Valo , "linux-wireless@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org List-ID: On Fri, Sep 1, 2017 at 1:02 PM, Arend van Spriel wrote: > Also note that the wifi chip (the term "radio" does not quite cover it) has > not really lost power. It is quite common that it is not powered through the > SDIO bus. With the power-sequence support in the MMC stack these days the > suspend may result in loss of power. Otherwise, it is just the bus that > loses power (and clock) and the flags affect what tricks the MMC stack tries > to pull to get the device accessible again upon resume. > Arend, Indeed - I'm familiar with the platform that Eric is using and it is exactly as you say: the chip is powered externally. There's some platform issues here that need to be resolved in addition, but the change to brcmfmac stands alone OK. > Maybe you can incorporate some of this in the commit message, but you should > at least add: > > Fixes: 330b4e4be937 ("brcmfmac: Add wowl support for SDIO devices.") > Fixes: bdf1340cf20f ("brcmfmac: fix sdio suspend and resume") > Reviewed-by: Arend van Spriel > >> Signed-off-by: Eric Bentley eric.bentley@lairdtech.com I've tested the patch on my platforms and works as expected. Eric, please add my: Tested-by: Steve deRosier Thanks, - Steve