Return-path: Received: from mx1.redhat.com ([209.132.183.28]:51215 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753237AbdIFNlD (ORCPT ); Wed, 6 Sep 2017 09:41:03 -0400 Date: Wed, 6 Sep 2017 15:40:57 +0200 From: Stefano Brivio To: Johannes Berg Cc: Matteo Croce , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: hung task in mac80211 Message-ID: <20170906154057.2de430a2@elisabeth> (sfid-20170906_154306_218987_8BAAF7C8) In-Reply-To: <1504704610.23905.1.camel@sipsolutions.net> References: <20170906144019.1c98a636@elisabeth> <1504702115.13457.16.camel@sipsolutions.net> <20170906151922.4a320b1d@elisabeth> <1504704060.13457.20.camel@sipsolutions.net> <20170906152709.673f230d@elisabeth> <1504704610.23905.1.camel@sipsolutions.net> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-wireless-owner@vger.kernel.org List-ID: On Wed, 06 Sep 2017 15:30:10 +0200 Johannes Berg wrote: > So for example replacing the loop of tid = 0..NUM_TIDS-1 with a > list_for_each_entry() would already be unsafe with the dropping if the > list were to require the mutex for locking. Sure. Still, it would need another code change to break, but in general I do agree indeed. :) -- Stefano