Return-path: Received: from youngberry.canonical.com ([91.189.89.112]:54500 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751999AbdI1I22 (ORCPT ); Thu, 28 Sep 2017 04:28:28 -0400 Received: from mail-wm0-f71.google.com ([74.125.82.71]) by youngberry.canonical.com with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1dxUBH-0006FF-UR for linux-wireless@vger.kernel.org; Thu, 28 Sep 2017 08:28:27 +0000 Received: by mail-wm0-f71.google.com with SMTP id 10so342645wmv.16 for ; Thu, 28 Sep 2017 01:28:27 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <878th14kde.fsf@kamboji.qca.qualcomm.com> References: <1506408099-18488-1-git-send-email-acelan.kao@canonical.com> <1506408099-18488-2-git-send-email-acelan.kao@canonical.com> <20170926064456.GA28611@infradead.org> <20170926140413.GA19977@infradead.org> <878th14kde.fsf@kamboji.qca.qualcomm.com> From: AceLan Kao Date: Thu, 28 Sep 2017 16:28:26 +0800 Message-ID: (sfid-20170928_102846_657202_1F8A1BBB) Subject: Re: [PATCH 2/6] ath9k: add a quirk to set use_msi automatically To: Kalle Valo Cc: Christoph Hellwig , QCA ath9k Development , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, "Linux-Kernel@Vger. Kernel. Org" , Daniel Drake Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi Christoph, I'm okay with ether ways, but just worrying the regression if we switch to use MSI by default. Hi Daniel, I've tried your patch, but it doesn't work for me. Wifi can scan AP, but can't get connected. It keeps showing [ 48.362297] wlp2s0: authenticate with 3c:ce:73:48:0e:40 [ 48.374445] wlp2s0: send auth to 3c:ce:73:48:0e:40 (try 1/3) [ 49.824071] wlp2s0: send auth to 3c:ce:73:48:0e:40 (try 2/3) [ 50.848143] wlp2s0: send auth to 3c:ce:73:48:0e:40 (try 3/3) [ 51.840078] wlp2s0: authentication with 3c:ce:73:48:0e:40 timed out [ 52.038561] wlp2s0: authenticate with 3c:ce:73:48:04:80 [ 52.058930] wlp2s0: send auth to 3c:ce:73:48:04:80 (try 1/3) [ 52.832063] wlp2s0: send auth to 3c:ce:73:48:04:80 (try 2/3) [ 53.824135] wlp2s0: send auth to 3c:ce:73:48:04:80 (try 3/3) [ 54.816067] wlp2s0: authentication with 3c:ce:73:48:04:80 timed out [ 55.904797] wlp2s0: authenticate with 3c:ce:73:48:04:80 [ 55.921771] wlp2s0: send auth to 3c:ce:73:48:04:80 (try 1/3) [ 56.800151] wlp2s0: send auth to 3c:ce:73:48:04:80 (try 2/3) [ 57.824072] wlp2s0: send auth to 3c:ce:73:48:04:80 (try 3/3) 02:00.0 Network controller [0280]: Qualcomm Atheros QCA9565 / AR9565 Wireless Network Adapter [168c:0036] (rev 01) Subsystem: Dell QCA9565 / AR9565 Wireless Network Adapter [1028:020e] Kernel driver in use: ath9k Kernel modules: ath9k Do you have a chance to see if my patch works on your side? Best regards, AceLan Kao. 2017-09-26 22:14 GMT+08:00 Kalle Valo : > Christoph Hellwig writes: > >> On Tue, Sep 26, 2017 at 03:26:51PM +0800, AceLan Kao wrote: >>> Ath9k is an old driver for old chips, and they work fine with legacy INTx. >>> But some new platforms are using it, so I think we should list those >>> new platforms which blocks INTx in the driver. >> >> And unless they are broken and need a quirk they should work even better >> with MSI if the device advertises MSI support in the PCI capabilities. > > Daniel Drake (CCed) already found problems with the MSI implementation: > > https://lkml.kernel.org/r/20170925041153.26574-1-drake@endlessm.com > > -- > Kalle Valo