Return-path: Received: from mail-pg0-f49.google.com ([74.125.83.49]:52137 "EHLO mail-pg0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756620AbdJKGyt (ORCPT ); Wed, 11 Oct 2017 02:54:49 -0400 Received: by mail-pg0-f49.google.com with SMTP id u144so521282pgb.8 for ; Tue, 10 Oct 2017 23:54:49 -0700 (PDT) Date: Tue, 10 Oct 2017 23:54:45 -0700 From: Bjorn Andersson To: Jia-Ju Bai Cc: k.eugene.e@gmail.com, kvalo@codeaurora.org, wcn36xx@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] wcn36xx: Remove unnecessary rcu_read_unlock in wcn36xx_bss_info_changed Message-ID: <20171011065445.GP1165@minitux> (sfid-20171011_085506_374824_B9E8731F) References: <1507467969-24016-1-git-send-email-baijiaju1990@163.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <1507467969-24016-1-git-send-email-baijiaju1990@163.com> Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sun 08 Oct 06:06 PDT 2017, Jia-Ju Bai wrote: > No rcu_read_lock is called, but rcu_read_unlock is still called. > Thus rcu_read_unlock should be removed. > Thanks, not sure how I could miss that one. Kalle can you please include this in a v4.14-rc pull request? : Fixes: 39efc7cc7ccf ("wcn36xx: Introduce mutual exclusion of fw configuration") > Signed-off-by: Jia-Ju Bai Acked-by: Bjorn Andersson Regards, Bjorn > --- > drivers/net/wireless/ath/wcn36xx/main.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/net/wireless/ath/wcn36xx/main.c b/drivers/net/wireless/ath/wcn36xx/main.c > index 35bd50b..b83f01d 100644 > --- a/drivers/net/wireless/ath/wcn36xx/main.c > +++ b/drivers/net/wireless/ath/wcn36xx/main.c > @@ -812,7 +812,6 @@ static void wcn36xx_bss_info_changed(struct ieee80211_hw *hw, > if (!sta) { > wcn36xx_err("sta %pM is not found\n", > bss_conf->bssid); > - rcu_read_unlock(); > goto out; > } > sta_priv = wcn36xx_sta_to_priv(sta); > -- > 1.7.9.5 > > > > _______________________________________________ > wcn36xx mailing list > wcn36xx@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/wcn36xx