From: Ganapathi Bhat <gbhat@marvell.com>
To: Brian Norris <briannorris@chromium.org>
CC: "linux-firmware@kernel.org" <linux-firmware@kernel.org>,
        "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
        James Cao <jcao@marvell.com>, Cathy Luo <cluo@marvell.com>,
        Mangesh Malusare <mmangesh@marvell.com>,
        Xinming Hu <huxm@marvell.com>,
        Zhiyuan Yang <yangzy@marvell.com>,
        Karthik Doddayennegere Ananthapadmanabha <karthida@marvell.com>
Subject: RE: [EXT] Re: pull-request mwifiex-firmware 2017-10-30
Date: Mon, 30 Oct 2017 18:47:58 +0000
Message-ID: <fb8d8eece601415c83167c500d80ff2f@SC-EXCH02.marvell.com> (sfid-20171030_194805_871589_E7219A8B)
References: <9370b3238604464b85bf0c4f8ac79c71@SC-EXCH02.marvell.com>
 <20171030170308.GA80479@google.com>
In-Reply-To: <20171030170308.GA80479@google.com>
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Sender: linux-wireless-owner@vger.kernel.org

Hi Brian,

>
> ----------------------------------------------------------------------
> On Mon, Oct 30, 2017 at 02:13:31PM +0000, Ganapathi Bhat wrote:
> > The following changes since commit
> e0494e95192ac5329989f4d128cf95c417d618cc:
> >
> >   linux-firmware: update Marvell PCIe-USB8997 firmware image (2017-08-01
> 23:55:30 +0530)
> >
> > are available in the git repository at:
> >
> >   git://git.marvell.com/mwifiex-firmware.git
> >
> > for you to fetch changes up to
> c5bed1294f6cf6bf6cbef612204f96361a3c2539:
> >
> >   linux-firmware: update Marvell PCIe-USB8997 firmware image (2017-10-30
> 19:23:05 +0530)
>
> Hooray, your git server is working again! And FWIW:
>
> Tested-by: Brian Norris <briannorris@chromium.org>
>
> But quoting your patch...
>
> > --- a/WHENCE
> > +++ b/WHENCE
> > @@ -757,7 +757,7 @@ File: mrvl/pcieuart8997_combo_v4.bin
> >  Version: 16.68.1.p70
> >
> >  File: mrvl/pcieusb8997_combo_v4.bin
> > -Version: 16.68.1.p133
> > +Version: 16.68.1.p40
>
> This says .p40, whereas the commit message (and the version tag within the
> firmware) says p140. I think you're missing a "1".
 I did miss this.  Will it make sense to trigger another pull request with just the version change?
>
> >
> >  File: mrvl/pcie8997_wlan_v4.bin
> >  Version: 16.68.1.p97
>
>
> Brian
>
> >
> > ----------------------------------------------------------------
> > Ganapathi Bhat (1):
> >       linux-firmware: update Marvell PCIe-USB8997 firmware image
> >
> > WHENCE                        |   2 +-
> > mrvl/pcieusb8997_combo_v4.bin | Bin 620800 -> 622532 bytes
> > 2 files changed, 1 insertion(+), 1 deletion(-)

Regards,
Ganapathi