Return-path: Received: from mail-wm0-f66.google.com ([74.125.82.66]:32769 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753408AbdJHTab (ORCPT ); Sun, 8 Oct 2017 15:30:31 -0400 From: Christos Gkekas To: Kalle Valo , ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Christos Gkekas Subject: [PATCH] ath10k: spectral: Simplify error checking Date: Sun, 8 Oct 2017 20:30:26 +0100 Message-Id: <1507491026-28690-1-git-send-email-chris.gekas@gmail.com> (sfid-20171008_213052_914514_55F654B9) Sender: linux-wireless-owner@vger.kernel.org List-ID: Variable val is unsigned so checking whether it is less than zero is redundant. Signed-off-by: Christos Gkekas --- drivers/net/wireless/ath/ath10k/spectral.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/net/wireless/ath/ath10k/spectral.c b/drivers/net/wireless/ath/ath10k/spectral.c index dd9cc09..1867937 100644 --- a/drivers/net/wireless/ath/ath10k/spectral.c +++ b/drivers/net/wireless/ath/ath10k/spectral.c @@ -403,10 +403,7 @@ static ssize_t write_file_spectral_count(struct file *file, return -EFAULT; buf[len] = '\0'; - if (kstrtoul(buf, 0, &val)) - return -EINVAL; - - if (val < 0 || val > 255) + if (kstrtoul(buf, 0, &val) || val > 255) return -EINVAL; mutex_lock(&ar->conf_mutex); -- 2.7.4