Return-path: Received: from mail-qt0-f193.google.com ([209.85.216.193]:44062 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751171AbdJCIJv (ORCPT ); Tue, 3 Oct 2017 04:09:51 -0400 MIME-Version: 1.0 In-Reply-To: <20171002212214.30d7013a@blatinox-laptop.localdomain> References: <20171001193101.8898-1-jeremy.lefaure@lse.epita.fr> <20171001193101.8898-6-jeremy.lefaure@lse.epita.fr> <20171002212214.30d7013a@blatinox-laptop.localdomain> From: Andy Shevchenko Date: Tue, 3 Oct 2017 11:09:50 +0300 Message-ID: (sfid-20171003_101022_409541_BAEAD569) Subject: Re: [PATCH 05/18] net: use ARRAY_SIZE To: =?UTF-8?B?SsOpcsOpbXkgTGVmYXVyZQ==?= Cc: Sathya Perla , Ajit Khaparde , Sriharsha Basavapatna , Somnath Kotur , Jeff Kirsher , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , Kalle Valo , Larry Finger , Chaoming Li , "David S. Miller" , Alexey Kuznetsov , Hideaki YOSHIFUJI , netdev , "linux-kernel@vger.kernel.org" , intel-wired-lan@lists.osuosl.org, USB , "open list:TI WILINK WIRELES..." , "open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER" , brcm80211-dev-list@cypress.com Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, Oct 3, 2017 at 4:22 AM, J=C3=A9r=C3=A9my Lefaure wrote: > On Mon, 2 Oct 2017 16:07:36 +0300 > Andy Shevchenko wrote: > >> > + {&gainctrl_lut_core0_rev0, ARRAY_SIZE(gainctrl_lut_core0_rev0)= , 26, 192, >> > + 32}, >> >> For all such cases I would rather put on one line disregard checkpatch >> warning for better readability. > I agree that it would be better. I didn't know that it was possible to > not follow this rule for anything else than a string. IMO, it increases readability quite enough to overrule checkpatch recomenda= tion. --=20 With Best Regards, Andy Shevchenko