Return-path: Received: from alexa-out.qualcomm.com ([129.46.98.28]:49185 "EHLO alexa-out.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752447AbdJ3IjX (ORCPT ); Mon, 30 Oct 2017 04:39:23 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Subject: Re: [v3] ath10k: rebuild crypto header in rx data frames From: Kalle Valo In-Reply-To: <1509035774-26553-1-git-send-email-kvalo@qca.qualcomm.com> References: <1509035774-26553-1-git-send-email-kvalo@qca.qualcomm.com> To: Kalle Valo CC: , , Vasanthakumar Thiagarajan Message-ID: <59b2ec22dc9c4db0bd30a65dba660b1c@euamsexm01a.eu.qualcomm.com> (sfid-20171030_093931_832947_D0061DAF) Date: Mon, 30 Oct 2017 09:39:16 +0100 Sender: linux-wireless-owner@vger.kernel.org List-ID: Kalle Valo wrote: > Rx data frames notified through HTT_T2H_MSG_TYPE_RX_IND and > HTT_T2H_MSG_TYPE_RX_FRAG_IND expect PN/TSC check to be done > on host (mac80211) rather than firmware. Rebuild cipher header > in every received data frames (that are notified through those > HTT interfaces) from the rx_hdr_status tlv available in the > rx descriptor of the first msdu. Skip setting RX_FLAG_IV_STRIPPED > flag for the packets which requires mac80211 PN/TSC check support > and set appropriate RX_FLAG for stripped crypto tail. Hw QCA988X, > QCA9887, QCA99X0, QCA9984, QCA9888 and QCA4019 currently need the > rebuilding of cipher header to perform PN/TSC check for replay > attack. > > Please note that removing crypto tail for CCMP-256, GCMP and GCMP-256 ciphers > in raw mode needs to be fixed. Since Rx with these ciphers in raw > mode does not work in the current form even without this patch and > removing crypto tail for these chipers needs clean up, raw mode related > issues in CCMP-256, GCMP and GCMP-256 can be addressed in follow up > patches. > > Tested-by: Manikanta Pubbisetty > Signed-off-by: Vasanthakumar Thiagarajan > Signed-off-by: Kalle Valo Patch applied to ath-current branch of ath.git, thanks. 7eccb738fce5 ath10k: rebuild crypto header in rx data frames -- https://patchwork.kernel.org/patch/10028621/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches