Return-path: Received: from paleale.coelho.fi ([176.9.41.70]:42222 "EHLO farmhouse.coelho.fi" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751949AbdJ2JvU (ORCPT ); Sun, 29 Oct 2017 05:51:20 -0400 From: Luca Coelho To: johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, Luca Coelho Date: Sun, 29 Oct 2017 11:51:10 +0200 Message-Id: <20171029095111.17078-5-luca@coelho.fi> (sfid-20171029_105207_479002_A560AA77) In-Reply-To: <20171029095111.17078-1-luca@coelho.fi> References: <20171029095111.17078-1-luca@coelho.fi> Subject: [PATCH 4/5] mac80211: remove BUG() when interface type is invalid Sender: linux-wireless-owner@vger.kernel.org List-ID: From: Luca Coelho In the ieee80211_setup_sdata() we check if the interface type is valid and, if not, call BUG(). This should never happen, but if there is something wrong with the code, it will not be caught until the bug happens when an interface is being set up. Calling BUG() is too extreme for this and a WARN_ON() would be better used instead. Change that. Signed-off-by: Luca Coelho --- net/mac80211/iface.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c index 435e7358004c..5fe01f82df12 100644 --- a/net/mac80211/iface.c +++ b/net/mac80211/iface.c @@ -1474,7 +1474,7 @@ static void ieee80211_setup_sdata(struct ieee80211_sub_if_data *sdata, break; case NL80211_IFTYPE_UNSPECIFIED: case NUM_NL80211_IFTYPES: - BUG(); + WARN_ON(1); break; } -- 2.14.2