Date: Thu, 5 Oct 2017 08:09:02 -0700
From: Stephen Hemminger <stephen@networkplumber.org>
To: Colin King <colin.king@canonical.com>
Cc: Samuel Ortiz <sameo@linux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        "David S . Miller" <davem@davemloft.net>,
        Johannes Berg <johannes.berg@intel.com>,
        linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] NFC: fdp: make struct nci_ops static
Message-ID: <20171005080902.30b95db3@xeon-e3> (sfid-20171005_170931_290990_21CA89C3)
In-Reply-To: <20171005094712.28627-1-colin.king@canonical.com>
References: <20171005094712.28627-1-colin.king@canonical.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Sender: linux-wireless-owner@vger.kernel.org

On Thu,  5 Oct 2017 10:47:12 +0100
Colin King <colin.king@canonical.com> wrote:

> From: Colin Ian King <colin.king@canonical.com>
> 
> The structure nci_ops is local to the source and does not need to
> be in global scope, so make it static.
> 
> Cleans up sparse warning:
> symbol 'nci_ops' was not declared. Should it be static?
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
>  drivers/nfc/fdp/fdp.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/nfc/fdp/fdp.c b/drivers/nfc/fdp/fdp.c
> index ec50027b0d8b..d5784a47fc13 100644
> --- a/drivers/nfc/fdp/fdp.c
> +++ b/drivers/nfc/fdp/fdp.c
> @@ -726,7 +726,7 @@ static struct nci_driver_ops fdp_prop_ops[] = {
>  	},
>  };
>  
> -struct nci_ops nci_ops = {
> +static struct nci_ops nci_ops = {
>  	.open = fdp_nci_open,
>  	.close = fdp_nci_close,
>  	.send = fdp_nci_send,

Why not static const?

Yes this goes deeper. NFC needs to make all nfc ops const.