Return-path: Received: from blatinox.fr ([51.254.120.209]:41817 "EHLO vps202351.ovh.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751250AbdJCBid (ORCPT ); Mon, 2 Oct 2017 21:38:33 -0400 Date: Mon, 2 Oct 2017 21:22:14 -0400 From: =?UTF-8?B?SsOpcsOpbXk=?= Lefaure To: Andy Shevchenko Cc: Sathya Perla , Ajit Khaparde , Sriharsha Basavapatna , Somnath Kotur , Jeff Kirsher , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , Kalle Valo , Larry Finger , Chaoming Li , "David S. Miller" , Alexey Kuznetsov , Hideaki YOSHIFUJI , netdev , "linux-kernel@vger.kernel.org" , intel-wired-lan@lists.osuosl.org, USB , "open list:TI WILINK WIRELES..." , "open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER" , brcm80211-dev-list@cypress.com Subject: Re: [PATCH 05/18] net: use ARRAY_SIZE Message-ID: <20171002212214.30d7013a@blatinox-laptop.localdomain> (sfid-20171003_033846_353042_AD7A294F) In-Reply-To: References: <20171001193101.8898-1-jeremy.lefaure@lse.epita.fr> <20171001193101.8898-6-jeremy.lefaure@lse.epita.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Mon, 2 Oct 2017 16:07:36 +0300 Andy Shevchenko wrote: > > + {&gainctrl_lut_core0_rev0, ARRAY_SIZE(gainctrl_lut_core0_rev0), 26, 192, > > + 32}, > > For all such cases I would rather put on one line disregard checkpatch > warning for better readability. I agree that it would be better. I didn't know that it was possible to not follow this rule for anything else than a string. I am waiting for more comments and I will send a v2. Thank you, Jérémy