Return-path: Received: from mail2.candelatech.com ([208.74.158.173]:57734 "EHLO mail2.candelatech.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751701AbdJJTfA (ORCPT ); Tue, 10 Oct 2017 15:35:00 -0400 Subject: Re: What should setting rate on 'AP' interface mean? To: Adrian Chadd References: Cc: ath10k , "linux-wireless@vger.kernel.org" From: Ben Greear Message-ID: <32d357fe-5904-4e8d-2a1e-84a16f498e06@candelatech.com> (sfid-20171010_213505_015258_1A056D55) Date: Tue, 10 Oct 2017 12:34:59 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: On 10/10/2017 12:09 PM, Adrian Chadd wrote: > Hi, > > IIRC, I think it's the drivers job to determine per-peer fixed rate. From poking at the 10.1 firmware source, seems that setting fixed RC on the vdev should over-ride all of the stations, but it did not appear to be working as expected... While trying to debug that, I hit a kernel lockup on rmmod ...it is hard to make progress some days! Thanks, Ben > > > > -adrian > > > On 10 October 2017 at 11:34, Ben Greear wrote: >> I was trying to use 'iw' to set rates on an AP interface, hoping it would >> set tx-rates on all of the stations (peers) to the same thing. >> >> It appears that the ath10k driver will set ratesets on all stations if >> we specify more than one rate, but if we specify a single rate, it does >> not iterate through all stations, and just sets the 'vdev' fixed rate. >> >> So, should the driver somehow attempt to set single rate on all the stations >> when >> using a single rate? >> >> Or, do we need an API to force rates for individual stations (peers) and >> leave >> the driver in the current configuration? >> >> Or is it the firmware's responsibility to set the rate for all peers when >> we set the vdev fixed rate on an AP vdev? >> >> Thanks, >> Ben >> >> -- >> Ben Greear >> Candela Technologies Inc http://www.candelatech.com >> > -- Ben Greear Candela Technologies Inc http://www.candelatech.com