Return-path: Received: from mail-wr0-f195.google.com ([209.85.128.195]:34278 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751109AbdJNIQJ (ORCPT ); Sat, 14 Oct 2017 04:16:09 -0400 Date: Sat, 14 Oct 2017 09:16:07 +0100 From: Christos Gkekas To: Kalle Valo Cc: QCA ath9k Development , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ath9k: debug: Simplify error checking Message-ID: <20171014081607.GB3961@inspiron> (sfid-20171014_101911_320455_30425A0B) References: <1507498152-4058-1-git-send-email-chris.gekas@gmail.com> <87infjw6us.fsf@purkki.adurom.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 In-Reply-To: <87infjw6us.fsf@purkki.adurom.net> Sender: linux-wireless-owner@vger.kernel.org List-ID: On 13/10/17 15:49:15 +0300, Kalle Valo wrote: > Christos Gkekas writes: > > > Variable val is unsigned so checking whether it is less than zero is > > redundant. > > > > Signed-off-by: Christos Gkekas > > --- > > drivers/net/wireless/ath/ath9k/debug.c | 5 +---- > > 1 file changed, 1 insertion(+), 4 deletions(-) > > > > diff --git a/drivers/net/wireless/ath/ath9k/debug.c b/drivers/net/wireless/ath/ath9k/debug.c > > index 01fa301..3b93c23 100644 > > --- a/drivers/net/wireless/ath/ath9k/debug.c > > +++ b/drivers/net/wireless/ath/ath9k/debug.c > > @@ -1164,10 +1164,7 @@ static ssize_t write_file_tpc(struct file *file, const char __user *user_buf, > > return -EFAULT; > > > > buf[len] = '\0'; > > - if (kstrtoul(buf, 0, &val)) > > - return -EINVAL; > > - > > - if (val < 0 || val > 1) > > + if (kstrtoul(buf, 0, &val) || val > 1) > > return -EINVAL; > > Same as with the ath10k patch, please keep the two if statements > separate. > > -- > Kalle Valo Thanks, will submit an new, updated patch. Christos Gkekas