Return-path: Received: from mail-wm0-f65.google.com ([74.125.82.65]:45061 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751653AbdJNJlU (ORCPT ); Sat, 14 Oct 2017 05:41:20 -0400 From: Christos Gkekas To: Kalle Valo , ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Christos Gkekas Subject: [PATCH] ath10k: spectral: Remove redundant check Date: Sat, 14 Oct 2017 10:41:15 +0100 Message-Id: <1507974075-6987-1-git-send-email-chris.gekas@gmail.com> (sfid-20171014_114142_812332_10AEA3A4) Sender: linux-wireless-owner@vger.kernel.org List-ID: Variable val is unsigned, so checking whether it is less than zero is redundant. Signed-off-by: Christos Gkekas --- drivers/net/wireless/ath/ath10k/spectral.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/spectral.c b/drivers/net/wireless/ath/ath10k/spectral.c index dd9cc09..2048b1e 100644 --- a/drivers/net/wireless/ath/ath10k/spectral.c +++ b/drivers/net/wireless/ath/ath10k/spectral.c @@ -406,7 +406,7 @@ static ssize_t write_file_spectral_count(struct file *file, if (kstrtoul(buf, 0, &val)) return -EINVAL; - if (val < 0 || val > 255) + if (val > 255) return -EINVAL; mutex_lock(&ar->conf_mutex); -- 2.7.4