Return-path: Received: from mail-pg0-f67.google.com ([74.125.83.67]:35701 "EHLO mail-pg0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753402AbdKXLl1 (ORCPT ); Fri, 24 Nov 2017 06:41:27 -0500 Received: by mail-pg0-f67.google.com with SMTP id l19so15246998pgo.2 for ; Fri, 24 Nov 2017 03:41:27 -0800 (PST) From: venkat.prashanth2498@gmail.com To: gregkh@linuxfoundation.org, linux-wireless@vger.kernel.org Cc: chaoming_li@realsil.com.cn, Larry.Finger@lwfinger.net, Venkat Prashanth B U Subject: [PATCH v3] rtlwifi:rtl8723ae:add the function name to the printouts Date: Fri, 24 Nov 2017 17:11:20 +0530 Message-Id: <1511523680-5033-1-git-send-email-venkat.prashanth2498@gmail.com> (sfid-20171124_124131_898805_5F610BAA) Sender: linux-wireless-owner@vger.kernel.org List-ID: From: Venkat Prashanth B U Prefer and make it generic by using %s and __func__ to print function name Change Log: v2: a. RT_TRACE(rtlpriv, COMP_SEND, DBG_TRACE, "\n"); The function name is not necessary in above code according to conditions as mentioned in comments. b. modified the commit message according to suggested comments. c. fixed the alignment issues. v1: a. Sign-off line is saperated from subject line from earlier patch version. Signed-off-by: Venkat Prashanth B U --- drivers/net/wireless/realtek/rtlwifi/rtl8723ae/trx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/trx.c b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/trx.c index f713c72..09c4e14 100644 --- a/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/trx.c +++ b/drivers/net/wireless/realtek/rtlwifi/rtl8723ae/trx.c @@ -389,7 +389,7 @@ void rtl8723e_tx_fill_desc(struct ieee80211_hw *hw, if (pci_dma_mapping_error(rtlpci->pdev, mapping)) { RT_TRACE(rtlpriv, COMP_SEND, DBG_TRACE, - "DMA mapping error\n"); + "%s():DMA mapping error\n", __func__); return; } if (mac->opmode == NL80211_IFTYPE_STATION) { @@ -498,7 +498,7 @@ void rtl8723e_tx_fill_desc(struct ieee80211_hw *hw, if (ieee80211_is_data_qos(fc)) { if (mac->rdg_en) { RT_TRACE(rtlpriv, COMP_SEND, DBG_TRACE, - "Enable RDG function.\n"); + "%s():Enable RDG function.\n", __func__); SET_TX_DESC_RDG_ENABLE(pdesc, 1); SET_TX_DESC_HTC(pdesc, 1); } @@ -557,7 +557,7 @@ void rtl8723e_tx_fill_cmddesc(struct ieee80211_hw *hw, if (pci_dma_mapping_error(rtlpci->pdev, mapping)) { RT_TRACE(rtlpriv, COMP_SEND, DBG_TRACE, - "DMA mapping error\n"); + "%s():DMA mapping error\n", __func__); return; } CLEAR_PCI_TX_DESC_CONTENT(pdesc, TX_DESC_SIZE); -- 1.9.1