Return-path: Received: from alexa-out.qualcomm.com ([129.46.98.28]:17838 "EHLO alexa-out.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758068AbdLROgn (ORCPT ); Mon, 18 Dec 2017 09:36:43 -0500 From: Kalle Valo To: Arnd Bergmann CC: qca_merez , QCA_ailizaro , qca_dlansky , QCA_hkadmany , qca_liord , QCA_gidons , "linux-wireless@vger.kernel.org" , wil6210 , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] wil6210: fix build warnings without CONFIG_PM Date: Mon, 18 Dec 2017 14:36:37 +0000 Message-ID: <87zi6gje6j.fsf@kamboji.qca.qualcomm.com> (sfid-20171218_153727_455909_9EE20184) References: <20171218134604.3087909-1-arnd@arndb.de> In-Reply-To: <20171218134604.3087909-1-arnd@arndb.de> (Arnd Bergmann's message of "Mon, 18 Dec 2017 14:45:51 +0100") Content-Type: text/plain; charset="iso-8859-1" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: Arnd Bergmann writes: > The #ifdef checks are hard to get right, in this case some functions > should have been left inside a CONFIG_PM_SLEEP check as seen by this > message: > > drivers/net/wireless/ath/wil6210/pcie_bus.c:489:12: error: 'wil6210_pm_re= sume' defined but not used [-Werror=3Dunused-function] > drivers/net/wireless/ath/wil6210/pcie_bus.c:484:12: error: 'wil6210_pm_su= spend' defined but not used [-Werror=3Dunused-function] > > Using an __maybe_unused is easier here, so I'm replacing all the > other #ifdef in this file as well for consistency. > > Fixes: 94162666cd51 ("wil6210: run-time PM when interface down") > Signed-off-by: Arnd Bergmann A note to myself (unfortunately patchwork doesn't have any way to add notes to patches): 94162666cd51 is in wireless-drivers-next so this patch should also go to -next. --=20 Kalle Valo=