Return-path: Received: from mail-qk0-f194.google.com ([209.85.220.194]:35116 "EHLO mail-qk0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750880AbdLaMHM (ORCPT ); Sun, 31 Dec 2017 07:07:12 -0500 MIME-Version: 1.0 In-Reply-To: <1514649113-7366-1-git-send-email-himanshujha199640@gmail.com> References: <1514649113-7366-1-git-send-email-himanshujha199640@gmail.com> From: Andy Shevchenko Date: Sun, 31 Dec 2017 14:07:10 +0200 Message-ID: (sfid-20171231_130733_217018_04BDB974) Subject: Re: [PATCH] brcmfmac: Use zeroing memory allocator than allocator/memset To: Himanshu Jha Cc: Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , Kalle Valo , "open list:TI WILINK WIRELES..." , "open list:BROADCOM BRCM80211 IEEE802.11n WIRELESS DRIVER" , brcm80211-dev-list@cypress.com, netdev , Linux Kernel Mailing List , "Luis R. Rodriguez" Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org List-ID: On Sat, Dec 30, 2017 at 5:51 PM, Himanshu Jha wrote: > Use dma_zalloc_coherent for allocating zeroed > memory and remove unnecessary memset function. > > Done using Coccinelle. > Generated-by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci > 0-day tested with no failures. > Makes sense. Reviewed-by: Andy Shevchenko > Suggested-by: Luis R. Rodriguez > Signed-off-by: Himanshu Jha > --- > .../net/wireless/broadcom/brcm80211/brcmfmac/pcie.c | 18 ++++++++---------- > 1 file changed, 8 insertions(+), 10 deletions(-) > > diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c > index 3c87157..bdef2ac 100644 > --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c > +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c > @@ -1251,14 +1251,13 @@ static int brcmf_pcie_init_scratchbuffers(struct brcmf_pciedev_info *devinfo) > u64 address; > u32 addr; > > - devinfo->shared.scratch = dma_alloc_coherent(&devinfo->pdev->dev, > - BRCMF_DMA_D2H_SCRATCH_BUF_LEN, > - &devinfo->shared.scratch_dmahandle, GFP_KERNEL); > + devinfo->shared.scratch = > + dma_zalloc_coherent(&devinfo->pdev->dev, > + BRCMF_DMA_D2H_SCRATCH_BUF_LEN, > + &devinfo->shared.scratch_dmahandle, > + GFP_KERNEL); > if (!devinfo->shared.scratch) > goto fail; > > - memset(devinfo->shared.scratch, 0, BRCMF_DMA_D2H_SCRATCH_BUF_LEN); > - > addr = devinfo->shared.tcm_base_address + > BRCMF_SHARED_DMA_SCRATCH_ADDR_OFFSET; > address = (u64)devinfo->shared.scratch_dmahandle; > @@ -1268,14 +1267,13 @@ static int brcmf_pcie_init_scratchbuffers(struct brcmf_pciedev_info *devinfo) > BRCMF_SHARED_DMA_SCRATCH_LEN_OFFSET; > brcmf_pcie_write_tcm32(devinfo, addr, BRCMF_DMA_D2H_SCRATCH_BUF_LEN); > > - devinfo->shared.ringupd = dma_alloc_coherent(&devinfo->pdev->dev, > - BRCMF_DMA_D2H_RINGUPD_BUF_LEN, > - &devinfo->shared.ringupd_dmahandle, GFP_KERNEL); > + devinfo->shared.ringupd = > + dma_zalloc_coherent(&devinfo->pdev->dev, > + BRCMF_DMA_D2H_RINGUPD_BUF_LEN, > + &devinfo->shared.ringupd_dmahandle, > + GFP_KERNEL); > if (!devinfo->shared.ringupd) > goto fail; > > - memset(devinfo->shared.ringupd, 0, BRCMF_DMA_D2H_RINGUPD_BUF_LEN); > - > addr = devinfo->shared.tcm_base_address + > BRCMF_SHARED_DMA_RINGUPD_ADDR_OFFSET; > address = (u64)devinfo->shared.ringupd_dmahandle; > -- > 2.7.4 > -- With Best Regards, Andy Shevchenko