Return-path: Received: from ns.iliad.fr ([212.27.33.1]:50521 "EHLO ns.iliad.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751660AbdLAKxc (ORCPT ); Fri, 1 Dec 2017 05:53:32 -0500 Message-ID: <1512125137.38490.70.camel@sakura.staff.proxad.net> (sfid-20171201_115335_903121_4F24D943) Subject: Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4 From: Maxime Bizon Reply-To: mbizon@freebox.fr To: akolli@qti.qualcomm.com Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, akolli@codeaurora.org Date: Fri, 01 Dec 2017 11:45:37 +0100 In-Reply-To: <1512046701-14435-3-git-send-email-akolli@qti.qualcomm.com> References: <1512046701-14435-1-git-send-email-akolli@qti.qualcomm.com> <1512046701-14435-3-git-send-email-akolli@qti.qualcomm.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, 2017-11-30 at 18:28 +0530, akolli@qti.qualcomm.com wrote: Hello, > Tested on QCA9880 with firmware version 10.2.4.70.48. This should also > work with firmware branch 10.2.4-1.0-00029 I tried using your patch on 4.14 with firmware 10.2.4-1.0-00029 > Parse peer stats from pktlog packets and update the tx rate information > per STA. This way user space can query about transmit rate with iw: everything works ok, ath10k_update_per_peer_tx_stats() is called and ath10k_sta fields are updated correctly but tx bitrate is still 6 MBit/s in station dump # iw dev wlan1 station dump Station e4:42:a6:24:c8:95 (on wlan1) inactive time: 0 ms rx bytes: 222415 rx packets: 1678 tx bytes: 8511140 tx packets: 5828 tx retries: 0 tx failed: 4 rx drop misc: 2 signal: -39 [-54, -56, -39] dBm signal avg: -39 [-53, -55, -39] dBm tx bitrate: 6.0 MBit/s rx bitrate: 360.0 MBit/s VHT-MCS 8 40MHz short GI VHT-NSS 2 authorized: yes authenticated: yes associated: yes preamble: long WMM/WME: yes MFP: no TDLS peer: no DTIM period: 2 beacon interval:96 short slot time:yes connected time: 1136 seconds I see that ath10k does not implement ->dump_station callback, so which part of the code updates the generic "struct station_info" fields ? Am I missing a patch ? Thanks -- Maxime