Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:33610 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752911AbdLEJzD (ORCPT ); Tue, 5 Dec 2017 04:55:03 -0500 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Subject: Re: [v1] brcmfmac: Avoid build error with make W=1 From: Kalle Valo In-Reply-To: <20171123155704.44878-1-andriy.shevchenko@linux.intel.com> References: <20171123155704.44878-1-andriy.shevchenko@linux.intel.com> To: Andy Shevchenko Cc: Arend van Spriel , Franky Lin , Hante Meuleman , Chi-Hsien Lin , Wright Feng , brcm80211-dev-list.pdl@broadcom.com, brcm80211-dev-list@cypress.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Andy Shevchenko Message-Id: <20171205095502.E6B336087D@smtp.codeaurora.org> (sfid-20171205_105540_068859_E1D9D810) Date: Tue, 5 Dec 2017 09:55:02 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org List-ID: Andy Shevchenko wrote: > When I run make W=1 on gcc (Debian 7.2.0-16) 7.2.0 I got an error for > the first run, all next ones are okay. > > CC [M] drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.o > drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c:2078: error: Cannot parse struct or union! > scripts/Makefile.build:310: recipe for target 'drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.o' failed > > Seems like something happened with W=1 and wrong kernel doc format. > As a quick fix remove dubious /** in the code. > > Signed-off-by: Andy Shevchenko > Acked-by: Arend van Spriel I'll queue this to v4.15. -- https://patchwork.kernel.org/patch/10073021/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches