Return-path: Received: from mail.toke.dk ([52.28.52.200]:47599 "EHLO mail.toke.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752379AbdLANlR (ORCPT ); Fri, 1 Dec 2017 08:41:17 -0500 From: Toke =?utf-8?Q?H=C3=B8iland-J=C3=B8rgensen?= To: akolli@codeaurora.org, Kalle Valo Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org, Anilkumar Kolli , linux-wireless-owner@vger.kernel.org Subject: Re: [PATCH 2/2] ath10k: add per peer tx stats support for 10.2.4 In-Reply-To: <5080a68538fd2d883e15bacaa969661b@codeaurora.org> References: <1512046701-14435-1-git-send-email-akolli@qti.qualcomm.com> <1512046701-14435-3-git-send-email-akolli@qti.qualcomm.com> <87k1y7zqtj.fsf@kamboji.qca.qualcomm.com> <87bmjjzppd.fsf@kamboji.qca.qualcomm.com> <5080a68538fd2d883e15bacaa969661b@codeaurora.org> Date: Fri, 01 Dec 2017 14:41:13 +0100 Message-ID: <87r2se36rq.fsf@toke.dk> (sfid-20171201_144121_627282_61941D82) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: akolli@codeaurora.org writes: > On 2017-11-30 22:08, Kalle Valo wrote: >> Toke H=C3=B8iland-J=C3=B8rgensen writes: >>=20 >>>>> +struct ath10k_10_2_peer_tx_stats { >>>>> + u8 ratecode[PEER_STATS_FOR_NO_OF_PPDUS]; >>>>> + u8 success_pkts[PEER_STATS_FOR_NO_OF_PPDUS]; >>>>> + __le16 success_bytes[PEER_STATS_FOR_NO_OF_PPDUS]; >>>>> + u8 retry_pkts[PEER_STATS_FOR_NO_OF_PPDUS]; >>>>> + __le16 retry_bytes[PEER_STATS_FOR_NO_OF_PPDUS]; >>>>> + u8 failed_pkts[PEER_STATS_FOR_NO_OF_PPDUS]; >>>>> + __le16 failed_bytes[PEER_STATS_FOR_NO_OF_PPDUS]; >>>>> + u8 flags[PEER_STATS_FOR_NO_OF_PPDUS]; >>>>> + __le32 tx_duration; >>>>> + u8 tx_ppdu_cnt; >>>>> + u8 peer_id; >>>>> +} __packed; >>>>=20 >>>> Toke, hopefully the tx_duration value here helps with ATF >>>> implementation >>>> using QCA988X. >>>=20 >>> Awesome! What's the semantics of this field? Just total >>> duration spent serving that station in the reporting interval? >>> Does it include retry attempts? >>=20 >> I have no clue :) I just noticed this while I was reviewing the patch >> internally and immediately recalled our discussions at Seoul. I can try >> to find out, but that will take a long time as I have way too much=20 >> stuff >> pending at the moment. Hopefully someone more knowledgeable=20 >> (Anilkumar?) >> can chime in and help. > > tx_duration is aggregate time duration of 4 PPDU sent to STA. > FW sends these values for retry packets also. Great, that sounds like just what we need. Thanks for the pointer :) -Toke