Return-path: Received: from mout.web.de ([212.227.17.11]:57478 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752180AbeACUNZ (ORCPT ); Wed, 3 Jan 2018 15:13:25 -0500 Subject: [PATCH 2/2] wireless: libertas_tf: Improve a size determination in two functions From: SF Markus Elfring To: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, Arvind Yadav , Kalle Valo , Kees Cook Cc: LKML , kernel-janitors@vger.kernel.org References: Message-ID: <2887651c-f571-120e-1a63-1768db668ee4@users.sourceforge.net> (sfid-20180103_212621_027087_6AC7DE55) Date: Wed, 3 Jan 2018 21:13:19 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: From: Markus Elfring Date: Wed, 3 Jan 2018 21:02:17 +0100 Replace the specification of data structures by variable references as the parameter for the operator "sizeof" to make the corresponding size determination a bit safer according to the Linux coding style convention. Signed-off-by: Markus Elfring --- drivers/net/wireless/marvell/libertas_tf/if_usb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/net/wireless/marvell/libertas_tf/if_usb.c b/drivers/net/wireless/marvell/libertas_tf/if_usb.c index 9eebc84cd15a..98e81a6f2338 100644 --- a/drivers/net/wireless/marvell/libertas_tf/if_usb.c +++ b/drivers/net/wireless/marvell/libertas_tf/if_usb.c @@ -152,7 +152,7 @@ static int if_usb_probe(struct usb_interface *intf, lbtf_deb_enter(LBTF_DEB_USB); udev = interface_to_usbdev(intf); - cardp = kzalloc(sizeof(struct if_usb_card), GFP_KERNEL); + cardp = kzalloc(sizeof(*cardp), GFP_KERNEL); if (!cardp) goto error; @@ -536,8 +536,7 @@ static void if_usb_receive_fwload(struct urb *urb) return; } - syncfwheader = kmemdup(skb->data, sizeof(struct fwsyncheader), - GFP_ATOMIC); + syncfwheader = kmemdup(skb->data, sizeof(*syncfwheader), GFP_ATOMIC); if (!syncfwheader) { lbtf_deb_usbd(&cardp->udev->dev, "Failure to allocate syncfwheader\n"); -- 2.15.1