Return-path: Received: from mail-wm0-f65.google.com ([74.125.82.65]:45828 "EHLO mail-wm0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752624AbeACOES (ORCPT ); Wed, 3 Jan 2018 09:04:18 -0500 Received: by mail-wm0-f65.google.com with SMTP id 9so2829026wme.4 for ; Wed, 03 Jan 2018 06:04:17 -0800 (PST) Date: Wed, 3 Jan 2018 15:04:02 +0100 (CET) From: Enrico Mioso To: Stanislaw Gruszka cc: linux-wireless@vger.kernel.org, Johannes Berg , Daniel Golle , Arnd Bergmann , John Crispin , nbd@nbd.name Subject: Re: ieee80211 phy0: rt2x00queue_write_tx_frame: Error - Dropping frame due to full tx queue...? In-Reply-To: <20180103113540.GA10306@redhat.com> Message-ID: (sfid-20180103_150429_127794_A9C83101) References: <20171213152017.GA3554@redhat.com> <20171218152142.GA15414@redhat.com> <20171219122707.GA2672@redhat.com> <20171219125431.GB2672@redhat.com> <20171221142558.GB4655@redhat.com> <20180103113540.GA10306@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Sender: linux-wireless-owner@vger.kernel.org List-ID: I'll apply your patch and let you know. Thank you very very much for your help, patience, and re-posting the patch. Your work is very valuable, sorry for the slowness and not testing this before. Enrico On Wed, 3 Jan 2018, Stanislaw Gruszka wrote: > Date: Wed, 3 Jan 2018 12:35:41 > From: Stanislaw Gruszka > To: Enrico Mioso > Cc: linux-wireless@vger.kernel.org, Johannes Berg , > Daniel Golle , Arnd Bergmann , > John Crispin , nbd@nbd.name > Subject: Re: ieee80211 phy0: rt2x00queue_write_tx_frame: Error - Dropping > frame due to full tx queue...? > > Hi > > On Sun, Dec 24, 2017 at 01:19:06PM +0100, Enrico Mioso wrote: >> Unfortunately, the error di appear again. Still, I experienced no stalls. >> But i am starting to think this doesn't happen necessarily when a device is going out of range. Now I think I don't know when this triggers. > > >> Sun Dec 24 10:10:50 2017 authpriv.info dropbear[840]: Exit (root): Disconnect received >> Sun Dec 24 11:04:33 2017 kern.err kernel: [ 1510.616638] ieee80211 phy0: rt2x00queue_write_tx_frame: Error - Dropping frame due to full tx queue 2 >> Sun Dec 24 11:04:33 2017 kern.err kernel: [ 1510.626106] ieee80211 phy0: rt2x00queue_write_tx_frame: Error - Dropping frame due to full tx queue 2 >> Sun Dec 24 11:04:33 2017 kern.err kernel: [ 1510.635562] ieee80211 phy0: rt2x00queue_write_tx_frame: Error - Dropping frame due to full tx queue 2 > > I would also try bigger threshold for waking queue like > in below patch for those errors: > > diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00dev.c b/drivers/net/wireless/ralink/rt2x00/rt2x00dev.c > index 357c0941aaad..b8bdf57ed7ea 100644 > --- a/drivers/net/wireless/ralink/rt2x00/rt2x00dev.c > +++ b/drivers/net/wireless/ralink/rt2x00/rt2x00dev.c > @@ -416,7 +416,7 @@ static void rt2x00lib_clear_entry(struct rt2x00_dev *rt2x00dev, > * before it was stopped. > */ > spin_lock_bh(&entry->queue->tx_lock); > - if (!rt2x00queue_threshold(entry->queue)) > + if (rt2x00queue_available(queue) > 2*queue->threshold) > rt2x00queue_unpause_queue(entry->queue); > spin_unlock_bh(&entry->queue->tx_lock); > } >