Return-path: Received: from szxga07-in.huawei.com ([45.249.212.35]:54775 "EHLO huawei.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752062AbeARCRN (ORCPT ); Wed, 17 Jan 2018 21:17:13 -0500 From: Wei Yongjun To: Johannes Berg , Kalle Valo , Ben Hutchings CC: Wei Yongjun , , Subject: [PATCH net-next] mac80211_hwsim: fix possible memory leak in hwsim_new_radio_nl() Date: Thu, 18 Jan 2018 02:23:34 +0000 Message-ID: <1516242214-51095-1-git-send-email-weiyongjun1@huawei.com> (sfid-20180118_031717_789751_0746C925) Content-Type: text/plain; charset="ISO-8859-1" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: 'hwname' is malloced in hwsim_new_radio_nl() and should be freed before leaving from the error handling cases, otherwise it will cause memory leak. Fixes: ff4dd73dd2b4 ("mac80211_hwsim: check HWSIM_ATTR_RADIO_NAME length") Signed-off-by: Wei Yongjun --- drivers/net/wireless/mac80211_hwsim.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/net/wireless/mac80211_hwsim.c b/drivers/net/wireless/mac80211_hwsim.c index e542555..34052c1 100644 --- a/drivers/net/wireless/mac80211_hwsim.c +++ b/drivers/net/wireless/mac80211_hwsim.c @@ -3155,8 +3155,10 @@ static int hwsim_new_radio_nl(struct sk_buff *msg, struct genl_info *info) if (info->attrs[HWSIM_ATTR_REG_CUSTOM_REG]) { u32 idx = nla_get_u32(info->attrs[HWSIM_ATTR_REG_CUSTOM_REG]); - if (idx >= ARRAY_SIZE(hwsim_world_regdom_custom)) + if (idx >= ARRAY_SIZE(hwsim_world_regdom_custom)) { + kfree(hwname); return -EINVAL; + } param.regd = hwsim_world_regdom_custom[idx]; }