Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:50344 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932627AbeAOKLh (ORCPT ); Mon, 15 Jan 2018 05:11:37 -0500 From: Kalle Valo To: Guenter Roeck Cc: =?utf-8?Q?Rafa=C5=82_Mi=C5=82ecki?= , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Matt Redfearn , James Hogan , Linux MIPS Mailing List , matt.redfearn@mips.com Subject: Re: [PATCH] bcma: Fix 'allmodconfig' and BCMA builds on MIPS targets References: <1515965642-16259-1-git-send-email-linux@roeck-us.net> Date: Mon, 15 Jan 2018 12:11:33 +0200 In-Reply-To: (Guenter Roeck's message of "Sun, 14 Jan 2018 13:40:50 -0800") Message-ID: <87vag31ley.fsf@purkki.adurom.net> (sfid-20180115_111154_142542_9F91B882) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-wireless-owner@vger.kernel.org List-ID: Guenter Roeck writes: > [ copying linux-mips ] > > On 01/14/2018 01:34 PM, Guenter Roeck wrote: >> Mips builds with BCMA host mode enabled fail in mainline and -next >> with: >> >> In file included from include/linux/bcma/bcma.h:10:0, >> from drivers/bcma/bcma_private.h:9, >> from drivers/bcma/main.c:8: >> include/linux/bcma/bcma_driver_pci.h:218:24: error: >> field 'pci_controller' has incomplete type >> >> Bisect points to commit d41e6858ba58c ("MIPS: Kconfig: Set default MIPS >> system type as generic") as the culprit. Analysis shows that the commmit >> changes PCI configuration and enables PCI_DRIVERS_GENERIC. This in turn >> disables PCI_DRIVERS_LEGACY. 'struct pci_controller' is, however, only >> defined if PCI_DRIVERS_LEGACY is enabled. >> >> Ultimately that means that BCMA_DRIVER_PCI_HOSTMODE depends on >> PCI_DRIVERS_LEGACY. Add the missing dependency. >> >> Fixes: d41e6858ba58c ("MIPS: Kconfig: Set default MIPS system type as ...") >> Cc: Matt Redfearn >> Cc: James Hogan >> Signed-off-by: Guenter Roeck >> --- >> I am aware that this problem has been reported several times. I have >> not been able to find a fix, but I may have missed it. If so, my >> apologies for the noise. >> > I should have said "I have not been able to find a patch fixing it". > >> Also note that this is not the only fix required; commit d41e6858ba58c, >> as simple as it looks like, does a pretty good job messing up >> "mips:allmodconfig" builds. >> > ... nor did I find patch(es) fixing the other build problem(s) introduced > by d41e6858ba58c. As I forgot to cc linux-mips on my previous email: I'm planning to queue this for v4.15. Over the weeked I got this bcma patch, but don't know if it's related or not: bcma: Prevent build of PCI host features in module https://patchwork.kernel.org/patch/10161087/ And Guenter's patch is: https://patchwork.kernel.org/patch/10162839/ Which one should I take? Adding also Matt. And Matt also submitted similar patch for ssb: ssb: Prevent build of PCI host features in module https://patchwork.kernel.org/patch/10161131/ -- Kalle Valo