Return-path: Received: from mx3-rdu2.redhat.com ([66.187.233.73]:33856 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751049AbeBIOdN (ORCPT ); Fri, 9 Feb 2018 09:33:13 -0500 Date: Fri, 9 Feb 2018 15:33:11 +0100 From: Timothy Redaelli To: Kalle Valo Cc: , QCA ath9k Development , Felix Fietkau Subject: Re: [PATCH] ath9k: fix DFS detector synchronization Message-ID: <20180209153311.193e08e0@redhat.com> (sfid-20180209_153317_818392_4C863F8D) In-Reply-To: <87fu6aegmy.fsf@kamboji.qca.qualcomm.com> References: <87fu6aegmy.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-wireless-owner@vger.kernel.org List-ID: On Fri, 09 Feb 2018 10:01:09 +0200 Kalle Valo wrote: > Timothy Redaelli writes: > > > The code currently syncronize the DFS region only if curchan != 0, > > but hostapd launch DFS before the channel is set and so > > set_dfs_domain is never executed. > > > > CC: Felix Fietkau > > Signed-off-by: Timothy Redaelli > > What kind of bug does this fix? Please describe the symptoms from > user's point of view. With the current code radar detection (CAC) doesn't work on ath9k since "dpd_set_domain" is only called once with NL80211_DFS_UNSET (0) as region and so "dpd_add_pulse" always returns true (radar detected) without doing a real scan. You can test it easily with a kernel built with CONFIG_ATH9K_DFS_CERTIFIED and by using a simple hostapd configuration: interface=wlp1s0 hw_mode=a channel=acs_survey chanlist=100 104 108 112 116 120 124 128 132 136 140 ieee80211d=1 ieee80211h=1 country_code=US ieee80211n=1 wmm_enabled=1 ssid=testwifi