Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:36196 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932236AbeB1PHj (ORCPT ); Wed, 28 Feb 2018 10:07:39 -0500 From: Kalle Valo To: Lorenzo Bianconi Cc: Jakub Kicinski , linux-wireless@vger.kernel.org Subject: Re: [PATCH] mt7601u: make write with mask access atomic References: <5bb3bb069bdd4663b69b60b782432c2faddc1efc.1518734856.git.lorenzo.bianconi@redhat.com> <20180215151445.52e08b03@cakuba.netronome.com> <87tvu1dv5f.fsf@purkki.adurom.net> Date: Wed, 28 Feb 2018 17:07:33 +0200 In-Reply-To: (Lorenzo Bianconi's message of "Wed, 28 Feb 2018 16:04:58 +0100") Message-ID: <87vaehqhje.fsf@kamboji.qca.qualcomm.com> (sfid-20180228_160748_917043_FF8ADCF1) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org List-ID: Lorenzo Bianconi writes: >> Lorenzo Bianconi writes: >> >>>> On Thu, 15 Feb 2018 23:59:24 +0100, Lorenzo Bianconi wrote: >>>>> Introduce __mt7601u_rr and __mt7601u_vendor_single_wr routines in order >>>>> to make mt7601u_rmw and mt7601u_rmc atomic since it is possible that >>>>> read and write accesses of mt7601u_rmw/mt7601u_rmc can be interleaved >>>>> with a different write operation on the same register. >>>>> Moreover move write trace point in __mt7601u_vendor_single_wr >>>>> >>>>> Signed-off-by: Lorenzo Bianconi >>>> >>>> Could you provide an example of which accesses make it problematic? >>>> Is this fixing an actual bug? >>> >>> it is not an issue I had experimented, I noticed a theoretical race >>> reviewing the code. >> >> The commit log should always answer the question "Why?". If you find a >> theoretical issue in the code document that clearly in the commit log. >> That helps to choose correct tree and sending to stable releases etc. >> >> https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches#commit_log_does_not_answer_why > > I have already sent a v2: https://patchwork.kernel.org/patch/10225849/ > Is the commit message ok? Yeah, I already applied it. -- Kalle Valo