Return-path: Received: from mail-qt0-f193.google.com ([209.85.216.193]:36172 "EHLO mail-qt0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751644AbeBCQ2w (ORCPT ); Sat, 3 Feb 2018 11:28:52 -0500 MIME-Version: 1.0 In-Reply-To: <1516258057.410.55.camel@sipsolutions.net> References: <1516258057.410.55.camel@sipsolutions.net> From: Kevin Groeneveld Date: Sat, 3 Feb 2018 11:28:50 -0500 Message-ID: (sfid-20180203_172856_875693_1A86A3D7) Subject: Re: [PATCH] cfg80211: stop demanding lots of new stuff To: Johannes Berg Cc: Hugh Dickins , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, Jan 18, 2018 at 1:47 AM, Johannes Berg wrote: > On Wed, 2018-01-17 at 14:55 -0800, Hugh Dickins wrote: >> "make oldconfig" from 4.14 (when CONFIG_CFG80211_CERTIFICATION_ONUS >> is not set) to 4.15-rc, gets into asking lots of new questions, and >> configuring in unwanted stuff: I'm unsure of my Kconfig skills, but >> it looks like CFG80211_REQUIRE_SIGNED_REGDB's "default y" needs to >> be toned down when we don't even have CFG80211_CERTIFICATION_ONUS. > > No, this is wrong - we want default configurations to be able to load a > signed regulatory database and validate the signature. I had a similar reaction as Hugh when I recently updated a kernel config from 4.14 to 4.15. I barely understand the kernel config options in question so I don't really know what is right or wrong. But it seems strange to me that when you turn off CFG80211_CERTIFICATION_ONUS in menuconfig that the options which get hidden are forced on. When options are hidden like this I assume (maybe incorrectly) that they are dependent on the option I just turned off and that the now hidden options will also be off. Kevin