Return-path: Received: from youngberry.canonical.com ([91.189.89.112]:55024 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752246AbeBIEVq (ORCPT ); Thu, 8 Feb 2018 23:21:46 -0500 Received: from mail-pg0-f70.google.com ([74.125.83.70]) by youngberry.canonical.com with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.76) (envelope-from ) id 1ek0By-0004ND-TL for linux-wireless@vger.kernel.org; Fri, 09 Feb 2018 04:21:43 +0000 Received: by mail-pg0-f70.google.com with SMTP id e12so3039143pgu.11 for ; Thu, 08 Feb 2018 20:21:42 -0800 (PST) Content-Type: text/plain; charset=utf-8; delsp=yes; format=flowed Mime-Version: 1.0 (Mac OS X Mail 11.3 \(3445.6.9\)) Subject: Re: [PATCH] ath9k: turn on btcoex_enable as default From: Kai Heng Feng In-Reply-To: <56d650e6-d26f-087c-4e86-2e5d4e859414@nbd.name> Date: Fri, 9 Feb 2018 12:21:36 +0800 Cc: kvalo@codeaurora.org, ath9k-devel@qca.qualcomm.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Message-Id: (sfid-20180209_052206_289926_35253879) References: <20180208052801.15670-1-kai.heng.feng@canonical.com> <56d650e6-d26f-087c-4e86-2e5d4e859414@nbd.name> To: Felix Fietkau Sender: linux-wireless-owner@vger.kernel.org List-ID: Hi Felix, > On Feb 8, 2018, at 7:02 PM, Felix Fietkau wrote: > > On 2018-02-08 06:28, Kai-Heng Feng wrote: >> Without btcoex_enable, WiFi activies make both WiFi and Bluetooth >> unstable if there's a bluetooth connection. >> >> Enable this option when bt_ant_diversity is disabled. >> >> BugLink: https://bugs.launchpad.net/bugs/1746164 >> Signed-off-by: Kai-Heng Feng > I think this might cause regressions on devices that don't have > bluetooth. This probably either needs more EEPROM checks, or something > to selectively enable it only on affected platforms. > I think it’s better not to use dmi_match. This issue should affect more ath9k. And bluetooth peripherals are more than ever now, so it would be great to use BT out of the box. Can you take a look at the bug link, maybe there are other things caused the erratic behavior that I didn’t notice? Kai-Heng > - Felix