Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:60582 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750898AbeC0OS4 (ORCPT ); Tue, 27 Mar 2018 10:18:56 -0400 From: Kalle Valo To: Johannes Berg Cc: Amitkumar Karwar , linux-wireless , Amitkumar Karwar , Siva Rebbagondla , Prameela Rani Garnepudi Subject: Re: [PATCH 01/10] rsi: add support for hardware scan offload References: <1520260620-4694-1-git-send-email-amitkarwar@gmail.com> <1520260620-4694-2-git-send-email-amitkarwar@gmail.com> <87ina00zwv.fsf@purkki.adurom.net> <871sgl90im.fsf@kamboji.qca.qualcomm.com> <1521585123.19123.2.camel@sipsolutions.net> <1522156927.3050.25.camel@sipsolutions.net> Date: Tue, 27 Mar 2018 17:18:51 +0300 In-Reply-To: <1522156927.3050.25.camel@sipsolutions.net> (Johannes Berg's message of "Tue, 27 Mar 2018 15:22:07 +0200") Message-ID: <87po3pppo4.fsf@kamboji.qca.qualcomm.com> (sfid-20180327_161900_917784_A5FED24C) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-wireless-owner@vger.kernel.org List-ID: Johannes Berg writes: > On Fri, 2018-03-23 at 20:20 +0530, Amitkumar Karwar wrote: > >> > But maybe that's not really true at all? At least in one case it seems >> > you just kick off something called "bgscan". >> >> Yes. We have different scan implementations for device is connected >> and non-connected cases. In connected case, firmware will take care of >> timings when driver configures bgscan parameters due to power save and >> coex restrictions. In non-connected state, driver is taking care of >> it. >> I found hardware scan in mac80211 more suitable for our device. > > Yeah it's a bit odd though that you're still implementing software scan > :-) > > Perhaps we could make a special return code from the hwscan callback > that would tell mac80211 to fall back to software scanning, so you'd > only implement the connected case, and leave the rest up to mac80211? Hehe, this is exactly what I proposed during my review :) -- Kalle Valo